Weekly Digest (25 November, 2018 - 2 December, 2018)

[weekly-digest]

Here's the Weekly Digest for git-for-windows/git:

---

ISSUES

Last week 10 issues were created.
Of these, 8 issues have been closed and 2 issues are still open.

OPEN ISSUES

💚 #1959 provide simple option to set unix style on windows platform(Git Bash), by xheke
💚 #1951 “Not a valid executable” error in installer, by DaFri-Nochiterov

CLOSED ISSUES

❤️ #1960 oops, by WilliamTheMarsman
❤️ #1958 mingw: safeguard against compiling with -DUNICODE, by dscho
❤️ #1957 Fix MSVC/Visual Studio build, by dscho
❤️ #1956 Prepare for skipping git rebase -p tests on Azure Pipelines, by dscho
❤️ #1955 auto-updater suggests old version, by sschlesier
❤️ #1954 Git for Windows has stopped working, by bugsrep
❤️ #1953 git update-git-for-windows downgrades git from 2.19.2 to 2.19.1, by createdbyjurand
❤️ #1952 Git daemon broken on windows (WSAStartup), by learn-more

NOISY ISSUE

🔈 #1953 git update-git-for-windows downgrades git from 2.19.2 to 2.19.1, by createdbyjurand
It received 9 comments.

---

PULL REQUESTS

Last week, 6 pull requests were created, updated or merged.

UPDATED PULL REQUEST

Last week, 1 pull request was updated.
💛 #1666 mingw: Fix unlink for open files, by orgads

MERGED PULL REQUEST

Last week, 5 pull requests were merged.
💜 #1958 mingw: safeguard against compiling with -DUNICODE, by dscho
💜 #1957 Fix MSVC/Visual Studio build, by dscho
💜 #1956 Prepare for skipping git rebase -p tests on Azure Pipelines, by dscho
💜 #1937 fscache: teach fscache to use NtQueryDirectoryFile, by benpeart
💜 #1934 fscache: make fscache_enable() thread safe, by benpeart

---

COMMITS

Last week there were 13 commits.
🛠️ Merge pull request #1958 from dscho/ansi-unicode mingw: safeguard against compiling with -DUNICODE by dscho
🛠️ Merge pull request #1956 from dscho/azure-pipelines-skip-rebase-p Prepare for skipping git rebase -p tests on Azure Pipelines by dscho
🛠️ fixup! mingw: kill child processes in a gentler way Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de by dscho
🛠️ fixup! mingw: introduce code to detect whether we're inside a Windows container Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de by dscho
🛠️ mingw: use ANSI or Unicode functions explicitly For many Win32 functions, there actually exist two variants: one with the A suffix that takes ANSI parameters (char * or const char *) and one with the W suffix that takes Unicode parameters (wchar_t * or const wchar_t *). Let's be precise what we want to use. Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de by dscho
🛠️ Merge pull request #1957 from dscho/fix-msvc-build Fix MSVC/Visual Studio build by dscho
🛠️ fixup! contrib/buildsystems: add a backend for modern Visual Studio versions Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de by dscho
🛠️ squash! mingw: replace mingw_startup() hack after adjusting the MSVC linker flags to force it to use wmain(). Noticed by Ben Peart. Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de by dscho
🛠️ fixup! Add a build definition for Azure DevOps While we do not have the patches in master yet that allow skipping the git rebase -p tests, we will have that feature as soon as we rebase to the v2.20.0 release train. Let's prepare for that and save a couple of minutes in the Windows phase by simply not bothering to test the git rebase -p mode that will be deprecated hopefully soon. Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de by dscho
🛠️ Merge pull request #1937 from benpeart/fscache-NtQueryDirectoryFile-gfw fscache: teach fscache to use NtQueryDirectoryFile by dscho
🛠️ fscache: teach fscache to use NtQueryDirectoryFile Using FindFirstFileExW() requires the OS to allocate a 64K buffer for each directory and then free it when we call FindClose(). Update fscache to call the underlying kernel API NtQueryDirectoryFile so that we can do the buffer management ourselves. That allows us to allocate a single buffer for the lifetime of the cache and reuse it for each directory. This change improves performance of 'git status' by 18% in a repo with ~200K files and 30k folders. Documentation for NtQueryDirectoryFile can be found at: https://docs.microsoft.com/en-us/windows-hardware/drivers/ddi/content/ntifs/nf-ntifs-ntquerydirectoryfile https://docs.microsoft.com/en-us/windows/desktop/FileIO/file-attribute-constants https://docs.microsoft.com/en-us/windows/desktop/fileio/reparse-point-tags To determine if the specified directory is a symbolic link, inspect the FileAttributes member to see if the FILE_ATTRIBUTE_REPARSE_POINT flag is set. If so, EaSize will contain the reparse tag (this is a so far undocumented feature, but confirmed by the NTFS developers). To determine if the reparse point is a symbolic link (and not some other form of reparse point), test whether the tag value equals the value IO_REPARSE_TAG_SYMLINK. Signed-off-by: Ben Peart benpeart@microsoft.com by benpeart
🛠️ fixup! mingw: Windows Docker volumes are not symbolic links The code in question is unclear, and not everbody has the time to dig up the commit message for the commit that added it, so let's play nice and add an explanation as a code comment. Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de by dscho
🛠️ Merge pull request #1934 from benpeart/fscache-thread-safe-enable-gfw fscache: make fscache_enable() thread safe by dscho

---

CONTRIBUTORS

Last week there were 2 contributors.
👤 dscho
👤 benpeart

---

STARGAZERS

Last week there were 21 stagazers.
⭐ xtaens
⭐ aoshiwik
⭐ Trendymen
⭐ JoNoZW
⭐ Filgeary
⭐ Predelnik
⭐ boudreau
⭐ fbuireu
⭐ netddd
⭐ longweitao
⭐ xheke
⭐ snilwx
⭐ keybluei
⭐ indilo53
⭐ LeslieGerman
⭐ LuoDiKaiHua
⭐ WilliamTheMarsman
⭐ cjh-fr
⭐ whitemike889
⭐ BlackBlackBoy
⭐ ASMlover
You all are the stars! 🌟

---

RELEASES

Last week there were no releases.

---

That's all for last week, please 👀 Watch and ⭐ Star the repository git-for-windows/git to receive next weekly updates. 😃

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. 📆