mingw: safeguard against compiling with -DUNICODE
#1958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamill
approved these changes
Nov 28, 2018
For many Win32 functions, there actually exist two variants: one with the `A` suffix that takes ANSI parameters (`char *` or `const char *`) and one with the `W` suffix that takes Unicode parameters (`wchar_t *` or `const wchar_t *`). Let's be precise what we want to use. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
… container Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
to dscho/git
that referenced
this pull request
Nov 30, 2018
mingw: safeguard against compiling with `-DUNICODE`
dscho
added a commit
to dscho/git
that referenced
this pull request
Nov 30, 2018
mingw: safeguard against compiling with `-DUNICODE`
dscho
added a commit
to dscho/git
that referenced
this pull request
Dec 1, 2018
mingw: safeguard against compiling with `-DUNICODE`
dscho
added a commit
to dscho/git
that referenced
this pull request
Dec 9, 2018
mingw: safeguard against compiling with `-DUNICODE`
dscho
added a commit
to dscho/git
that referenced
this pull request
Dec 15, 2018
mingw: safeguard against compiling with `-DUNICODE`
dscho
added a commit
to dscho/git
that referenced
this pull request
Feb 7, 2019
mingw: safeguard against compiling with `-DUNICODE`
dscho
added a commit
to dscho/git
that referenced
this pull request
Feb 7, 2019
mingw: safeguard against compiling with `-DUNICODE`
dscho
added a commit
that referenced
this pull request
May 14, 2019
mingw: safeguard against compiling with `-DUNICODE`
dscho
added a commit
that referenced
this pull request
May 14, 2019
mingw: safeguard against compiling with `-DUNICODE`
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 19, 2019
mingw: safeguard against compiling with `-DUNICODE`
dscho
added a commit
to dscho/git
that referenced
this pull request
May 19, 2019
mingw: safeguard against compiling with `-DUNICODE`
dscho
added a commit
that referenced
this pull request
May 19, 2019
mingw: safeguard against compiling with `-DUNICODE`
dscho
added a commit
that referenced
this pull request
May 19, 2019
mingw: safeguard against compiling with `-DUNICODE`
dscho
added a commit
that referenced
this pull request
May 21, 2019
mingw: safeguard against compiling with `-DUNICODE`
dscho
added a commit
that referenced
this pull request
May 21, 2019
mingw: safeguard against compiling with `-DUNICODE`
dscho
added a commit
that referenced
this pull request
May 21, 2019
mingw: safeguard against compiling with `-DUNICODE`
dscho
added a commit
that referenced
this pull request
May 21, 2019
mingw: safeguard against compiling with `-DUNICODE`
dscho
added a commit
that referenced
this pull request
May 22, 2019
mingw: safeguard against compiling with `-DUNICODE`
dscho
added a commit
that referenced
this pull request
May 22, 2019
mingw: safeguard against compiling with `-DUNICODE`
dscho
added a commit
that referenced
this pull request
May 22, 2019
mingw: safeguard against compiling with `-DUNICODE`
dscho
added a commit
that referenced
this pull request
May 22, 2019
mingw: safeguard against compiling with `-DUNICODE`
dscho
added a commit
that referenced
this pull request
May 25, 2019
mingw: safeguard against compiling with `-DUNICODE`
dscho
added a commit
that referenced
this pull request
May 25, 2019
mingw: safeguard against compiling with `-DUNICODE`
dscho
added a commit
that referenced
this pull request
May 25, 2019
mingw: safeguard against compiling with `-DUNICODE`
dscho
added a commit
that referenced
this pull request
May 25, 2019
mingw: safeguard against compiling with `-DUNICODE`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While technically not necessary, it is nice to have code that compiles both with and without the
UNICODEconstant defined.Practically, this means that we have to use the
*A()and*W()variants of the Win32 API functions explicitly.