fscache: make fscache_enable() thread safe #1934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent change to make fscache thread specific relied on fscache_enable() being called first from the primary thread before being called in parallel from worker threads. Make that more robust and protect it with a critical section to avoid any issues. Helped-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Ben Peart <benpeart@microsoft.com>
|
@benpeart I rebased your patch on top of |
|
Thank you! The test failures are caused (for some dubious, and new reason) by the test suite all of a sudden not being able to remove the test directories reliably. Not the fault of these changes. |
dscho
added a commit
to dscho/git
that referenced
this pull request
Nov 27, 2018
…safe-enable-gfw fscache: make fscache_enable() thread safe
dscho
added a commit
to dscho/git
that referenced
this pull request
Nov 30, 2018
…safe-enable-gfw fscache: make fscache_enable() thread safe
dscho
added a commit
to dscho/git
that referenced
this pull request
Dec 1, 2018
…safe-enable-gfw fscache: make fscache_enable() thread safe
dscho
added a commit
to dscho/git
that referenced
this pull request
Dec 9, 2018
…safe-enable-gfw fscache: make fscache_enable() thread safe
dscho
added a commit
to dscho/git
that referenced
this pull request
Dec 15, 2018
…safe-enable-gfw fscache: make fscache_enable() thread safe
dscho
added a commit
to dscho/git
that referenced
this pull request
Feb 7, 2019
…safe-enable-gfw fscache: make fscache_enable() thread safe
dscho
added a commit
to dscho/git
that referenced
this pull request
Feb 7, 2019
…safe-enable-gfw fscache: make fscache_enable() thread safe
dscho
added a commit
that referenced
this pull request
Feb 12, 2019
fscache: make fscache_enable() thread safe
dscho
added a commit
that referenced
this pull request
Oct 8, 2024
fscache: make fscache_enable() thread safe
dscho
added a commit
that referenced
this pull request
Oct 8, 2024
fscache: make fscache_enable() thread safe
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 9, 2024
fscache: make fscache_enable() thread safe
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 9, 2024
fscache: make fscache_enable() thread safe
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 9, 2024
fscache: make fscache_enable() thread safe
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 9, 2024
fscache: make fscache_enable() thread safe
dscho
added a commit
that referenced
this pull request
Oct 9, 2024
fscache: make fscache_enable() thread safe
dscho
added a commit
that referenced
this pull request
Oct 9, 2024
fscache: make fscache_enable() thread safe
dscho
added a commit
that referenced
this pull request
Oct 10, 2024
fscache: make fscache_enable() thread safe
dscho
added a commit
that referenced
this pull request
Oct 10, 2024
fscache: make fscache_enable() thread safe
dscho
added a commit
that referenced
this pull request
Oct 10, 2024
fscache: make fscache_enable() thread safe
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 10, 2024
fscache: make fscache_enable() thread safe
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 10, 2024
fscache: make fscache_enable() thread safe
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 11, 2024
fscache: make fscache_enable() thread safe
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 11, 2024
fscache: make fscache_enable() thread safe
dscho
added a commit
that referenced
this pull request
Oct 11, 2024
fscache: make fscache_enable() thread safe
dscho
added a commit
that referenced
this pull request
Oct 11, 2024
fscache: make fscache_enable() thread safe
dscho
added a commit
that referenced
this pull request
Oct 11, 2024
fscache: make fscache_enable() thread safe
dscho
added a commit
that referenced
this pull request
Oct 20, 2024
fscache: make fscache_enable() thread safe
dscho
added a commit
that referenced
this pull request
Oct 20, 2024
fscache: make fscache_enable() thread safe
dscho
added a commit
that referenced
this pull request
Oct 21, 2024
fscache: make fscache_enable() thread safe
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 21, 2024
fscache: make fscache_enable() thread safe
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 21, 2024
fscache: make fscache_enable() thread safe
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 22, 2024
fscache: make fscache_enable() thread safe
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 22, 2024
fscache: make fscache_enable() thread safe
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 22, 2024
fscache: make fscache_enable() thread safe
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 22, 2024
fscache: make fscache_enable() thread safe
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 22, 2024
fscache: make fscache_enable() thread safe
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 22, 2024
fscache: make fscache_enable() thread safe
dscho
added a commit
that referenced
this pull request
Oct 23, 2024
fscache: make fscache_enable() thread safe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent change to make fscache thread specific relied on fscache_enable() called first from the primary thread before being called in parallel worker threads. Make that more robust and protect it with a critical
section to avoid any issues.
Helped-by: Johannes Schindelin johannes.schindelin@gmx.de
Signed-off-by: Ben Peart benpeart@microsoft.com