[git commit --interactive] BUG: pathspec.c:555: PATHSPEC_PREFER_CWD requires arguments

[leha-bot]

• I was not able to find an open or closed issue matching what I'm seeing

Setup

• Which version of Git for Windows are you using? Is it 32-bit or 64-bit?

$ git --version --build-options

git version 2.24.1.windows.2
cpu: x86_64
built from commit: 992f0773022527b1b0cb1e0c13aec97dd5248053
sizeof-long: 4
sizeof-size_t: 8

• Which version of Windows are you running? Vista, 7, 8, 10? Is it 32-bit or 64-bit?

$ cmd.exe /c ver
Microsoft Windows [Version 6.3.9600]

(64 bit)

• What options did you set as part of the installation? Or did you choose the
  defaults?

# One of the following:
> type "C:\Program Files\Git\etc\install-options.txt"
> type "C:\Program Files (x86)\Git\etc\install-options.txt"
> type "%USERPROFILE%\AppData\Local\Programs\Git\etc\install-options.txt"
$ cat /etc/install-options.txt

Editor Option: VIM
Custom Editor Path:
Path Option: Cmd
SSH Option: OpenSSH
Tortoise Option: false
CURL Option: OpenSSL
CRLF Option: CRLFAlways
Bash Terminal Option: MinTTY
Performance Tweaks FSCache: Enabled
Use Credential Manager: Enabled
Enable Symlinks: Disabled
Enable Builtin Interactive Add: Enabled

• Any other interesting things about your environment that might be related
  to the issue you're seeing?
  No.

Details

• Which terminal/shell are you running Git from? e.g Bash/CMD/PowerShell/other
  cmd/Git Bash
• What commands did you run to trigger this issue? If you can provide a
  Minimal, Complete, and Verifiable example
  this will help us understand the issue.

git commit --interactive
            staged     unstaged path
  1:    unchanged        +1/-0 CMakeLists.txt
  2:    unchanged     +14/-344 src/main.cpp
  3:    unchanged        +2/-0 src/tgbotlib/CMakeLists.txt

*** Commands ***
  1: status       2: update       3: revert       4: add untracked
  5: patch        6: diff         7: quit         8: help
What now> 5
            staged     unstaged path
  1:    unchanged        +1/-0 CMakeLists.txt
  2:    unchanged     +14/-344 src/main.cpp
  3:    unchanged        +2/-0 src/tgbotlib/CMakeLists.txt
Patch update>>
BUG: pathspec.c:555: PATHSPEC_PREFER_CWD requires arguments

This application has requested the Runtime to terminate it in an unusual way.
Please contact the application's support team for more information.

• What did you expect to occur after running these commands?
  I expect that I returned to previous menu (1 -status, 2 - update, 3 - revert ,etc.)

• What actually happened instead?
  See commands dump.

• If the problem was occurring with a specific repository, can you provide the
  URL to that repository to help us with testing?

I found that issue some releases ago on any repository with unstaged files.

[dscho]

I tried to reproduce, but failed:

me@work MINGW64 ~/repros/empty
$ echo 123 >file

me@work MINGW64 ~/repros/empty
$ git add -N file

me@work MINGW64 ~/repros/empty
$ git commit --interactive
warning: LF will be replaced by CRLF in file.
The file will have its original line endings in your working directory
            staged     unstaged path
  1:        +0/-0        +1/-0 file

*** Commands ***
  1: status       2: update       3: revert       4: add untracked
  5: patch        6: diff         7: quit         8: help
What now> 5
warning: LF will be replaced by CRLF in file.
The file will have its original line endings in your working directory
            staged     unstaged path
  1:        +0/-0        +1/-0 file
Patch update>> f
            staged     unstaged path
* 1:        +0/-0        +1/-0 file
Patch update>>
warning: LF will be replaced by CRLF in file.
The file will have its original line endings in your working directory
warning: LF will be replaced by CRLF in file.
The file will have its original line endings in your working directory
diff --git a/file b/file
index e69de29..190a180 100644
--- a/file
+++ b/file
@@ -0,0 +1,1 @@
+123
(1/1) Stage this hunk [y,n,q,a,d,e,?]? y

*** Commands ***
  1: status       2: update       3: revert       4: add untracked
  5: patch        6: diff         7: quit         8: help
What now> q
hint: Waiting for your editor to close the file... Bye.
[master (root-commit) 35a32a8] Worked...
 1 file changed, 1 insertion(+)
 create mode 100644 file

So I fear that there must be something special on your machine, or maybe you forgot to mention a detail. It would be good to have a reproducible script for this issue.

[dscho]

@leha-bot ping?

[qhill]

I encountered a similar issue with git version 2.24.1.windows.2 but with add interactive. I think what you need to change in your attempt to reproduce this is to not type f so:

$ git commit --interactive
warning: LF will be replaced by CRLF in file.
The file will have its original line endings in your working directory
            staged     unstaged path
  1:        +0/-0        +1/-0 file

*** Commands ***
  1: status       2: update       3: revert       4: add untracked
  5: patch        6: diff         7: quit         8: help
What now> 5
warning: LF will be replaced by CRLF in file.
The file will have its original line endings in your working directory
            staged     unstaged path
  1:        +0/-0        +1/-0 file
Patch update>> 
            staged     unstaged path
* 1:        +0/-0        +1/-0 file
Patch update>>

With 2.24.1.windows.2 the BUG appears. With git version 2.25.0.windows.1 the command just exits silently and immediately. The same thing happens with git add --interactive.

As an aside the rewrite of git add --interactive in C broke the ability to select files using an open range e.g. Patch update>> 2- to select all but the first file. This is related to this issue as attempting this results in the same behaviour as in this issue (i.e. BUG in 2.24.1.windows.2 and immediate exit in 2.25.0.windows.1).

[dscho]

I think what you need to change in your attempt to reproduce this is to not type f

That did the trick!

As an aside the rewrite of git add --interactive in C broke the ability to select files using an open range e.g. Patch update>> 2- to select all but the first file.

True. The code actually has a comment about it, but does the wrong thing...