Two fixes for the built-in git add -i
#2472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the user does not select any files to `patch` or `diff`, there is no need to call `run_add_p()` on them. Even worse: we _have_ to avoid calling `parse_pathspec()` with an empty list because that would trigger this error: BUG: pathspec.c:557: PATHSPEC_PREFER_CWD requires arguments So let's avoid doing any work on a list of files that is empty anyway. This fixes git-for-windows#2466. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
The interactive `add` command allows selecting multiple files for some of its sub-commands, via unique prefixes, indices or index ranges. When re-implementing `git add -i` in C, we even added a code comment talking about ranges with a missing end index, such as `2-`, but the code did not actually accept those, as pointed out in git-for-windows#2466 (comment). Let's fix this, and add a test case to verify that this stays fixed forever. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
force-pushed
the
builtin-add-i-fixes
branch
from
d5b6a16 to
ff8149b
Compare
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 16, 2020
Two fixes for the built-in `git add -i`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 16, 2020
Two fixes for the built-in `git add -i`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 16, 2020
Two fixes for the built-in `git add -i`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 17, 2020
Two fixes for the built-in `git add -i`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 17, 2020
Two fixes for the built-in `git add -i`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 17, 2020
Two fixes for the built-in `git add -i`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 22, 2020
Two fixes for the built-in `git add -i`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 22, 2020
Two fixes for the built-in `git add -i`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 22, 2020
Two fixes for the built-in `git add -i`
dscho
added a commit
that referenced
this pull request
Jan 23, 2020
Two fixes for the built-in `git add -i`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 24, 2020
Two fixes for the built-in `git add -i`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 27, 2020
Two fixes for the built-in `git add -i`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 27, 2020
Two fixes for the built-in `git add -i`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 29, 2020
Two fixes for the built-in `git add -i`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 29, 2020
Two fixes for the built-in `git add -i`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 31, 2020
Two fixes for the built-in `git add -i`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Feb 1, 2020
Two fixes for the built-in `git add -i`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Feb 10, 2020
Two fixes for the built-in `git add -i`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Feb 11, 2020
Two fixes for the built-in `git add -i`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Feb 13, 2020
Two fixes for the built-in `git add -i`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Feb 17, 2020
Two fixes for the built-in `git add -i`
dscho
added a commit
to dscho/git
that referenced
this pull request
Feb 17, 2020
Two fixes for the built-in `git add -i`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Feb 19, 2020
Two fixes for the built-in `git add -i`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Feb 26, 2020
Two fixes for the built-in `git add -i`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 5, 2020
Two fixes for the built-in `git add -i`
dscho
added a commit
that referenced
this pull request
Mar 10, 2020
Two fixes for the built-in `git add -i`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 11, 2020
Two fixes for the built-in `git add -i`
dscho
added a commit
that referenced
this pull request
Mar 17, 2020
Two fixes for the built-in `git add -i`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to address #2466.