Revert "enable fscache while iterating every local refs" #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please don't merge this PR before merging #1379 |
This reverts commit 09ccec4. Using fscache here is not right way. It is better to specify OBJECT_INFO_QUICK flag for has_object_file instead, as was done in Pull Request git-for-windows#1379. This flag prevents directory list up for each refs also. Signed-off-by: Takuto Ikuta <tikuta@chromium.org> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
force-pushed
the
revert_fscache
branch
from
50fd456 to
0b74f77
Compare
|
I amended the commit message to make it a "fixup!" commit, so that the original patch can be dropped next time I rebase all of Git for Windows' patches on top of core Git's next tagged version. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 09ccec4.
Using fscache here is not right way.
It is better to specify OBJECT_INFO_QUICK flag for has_object_file instead.
This flag prevents directory list up for each refs also.
Signed-off-by: Takuto Ikuta tikuta@chromium.org