Crash when hitting return in search results when nothing is selected #883

ghost · 2022-12-14T23:33:03Z

-------------------------------------
Translated Report (Full Report Below)
-------------------------------------

Process:               GitUp [3807]
Path:                  /Users/USER/*/GitUp.app/Contents/MacOS/GitUp
Identifier:            co.gitup.mac
Version:               1.3.4 (1047)
Code Type:             ARM-64 (Native)
Parent Process:        launchd [1]
User ID:               501

Date/Time:             2022-12-14 18:31:43.7627 -0500
OS Version:            macOS 12.6.2 (21G320)
Report Version:        12
Anonymous UUID:        6E4510AB-47F3-73CF-21DB-07A64B26A4A3

Sleep/Wake UUID:       595B35F4-A7CA-49FD-9B16-E749F59927DE

Time Awake Since Boot: 25000 seconds
Time Since Wake:       2735 seconds

System Integrity Protection: enabled

Crashed Thread:        0  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_BAD_ACCESS (SIGSEGV)
Exception Codes:       KERN_INVALID_ADDRESS at 0x0000000000000008
Exception Codes:       0x0000000000000001, 0x0000000000000008
Exception Note:        EXC_CORPSE_NOTIFY

Termination Reason:    Namespace SIGNAL, Code 11 Segmentation fault: 11
Terminating Process:   exc handler [3807]

VM Region Info: 0x8 is not in any region.  Bytes before following region: 105553518919672
      REGION TYPE                    START - END         [ VSIZE] PRT/MAX SHRMOD  REGION DETAIL
      UNUSED SPACE AT START
--->  
      MALLOC_NANO (reserved)   600018000000-600020000000 [128.0M] rw-/rwx SM=NUL  ...(unallocated)

Thread 0 Crashed::  Dispatch queue: com.apple.main-thread
0   GitUpKit                      	       0x1057c81dc -[GCObject(Extensions) isEqualToObject:] + 48
1   GitUpKit                      	       0x1057c81d8 -[GCObject(Extensions) isEqualToObject:] + 44
2   GitUpKit                      	       0x10580adb0 -[GCLiveRepository(Utilities) validateCheckoutCommit:] + 140
3   GitUpKit                      	       0x10580a21c -[GCLiveRepository(Utilities) smartCheckoutCommit:window:] + 76
4   GitUpKit                      	       0x105803924 -[GICommitListViewController smartCheckoutSelectedCommit] + 108
5   GitUpKit                      	       0x105803984 -[GICommitListViewController keyDown:] + 52
6   AppKit                        	       0x1ae7311d4 forwardMethod + 200
7   AppKit                        	       0x1ae7311d4 forwardMethod + 200
8   AppKit                        	       0x1ae7311d4 forwardMethod + 200
9   AppKit                        	       0x1ae7311d4 forwardMethod + 200
10  AppKit                        	       0x1ae897b94 -[NSControl keyDown:] + 124
11  AppKit                        	       0x1ae8ab32c -[NSTableView keyDown:] + 1000
12  GitUpKit                      	       0x1057f594c -[GITableView keyDown:] + 136
13  AppKit                        	       0x1ae6abe88 -[NSWindow(NSEventRouting) _reallySendEvent:isDelayedEvent:] + 5908
14  AppKit                        	       0x1ae6aa50c -[NSWindow(NSEventRouting) sendEvent:] + 348
15  GitUpKit                      	       0x105801288 -[GIWindow sendEvent:] + 228
16  AppKit                        	       0x1ae6a94b4 -[NSApplication(NSEvent) sendEvent:] + 2780
17  AppKit                        	       0x1ae9630f4 -[NSApplication _handleEvent:] + 76
18  AppKit                        	       0x1ae52b008 -[NSApplication run] + 636
19  AppKit                        	       0x1ae4fc6fc NSApplicationMain + 1132
20  dyld                          	       0x104ad508c start + 520

Thread 1:: com.apple.NSEventThread
0   libsystem_kernel.dylib        	       0x1ab8ca8b0 mach_msg_trap + 8
1   libsystem_kernel.dylib        	       0x1ab8cad20 mach_msg + 76
2   CoreFoundation                	       0x1ab9d5210 __CFRunLoopServiceMachPort + 372
3   CoreFoundation                	       0x1ab9d36c0 __CFRunLoopRun + 1180
4   CoreFoundation                	       0x1ab9d2a84 CFRunLoopRunSpecific + 600
5   AppKit                        	       0x1ae6a7100 _NSEventThread + 196
6   libsystem_pthread.dylib       	       0x1ab90826c _pthread_start + 148
7   libsystem_pthread.dylib       	       0x1ab90308c thread_start + 8

Thread 2:
0   libsystem_pthread.dylib       	       0x1ab903078 start_wqthread + 0

Thread 3:
0   libsystem_pthread.dylib       	       0x1ab903078 start_wqthread + 0

Thread 4:
0   libsystem_pthread.dylib       	       0x1ab903078 start_wqthread + 0

Thread 5:
0   libsystem_pthread.dylib       	       0x1ab903078 start_wqthread + 0


Thread 0 crashed with ARM Thread State (64-bit):
    x0: 0x0000600001f68820   x1: 0x00000001f65fffe9   x2: 0x0000000000000000   x3: 0x00000001568ab3f0
    x4: 0x0000000000000010   x5: 0x000000016b67ebe8   x6: 0x0000000000000001   x7: 0x0000000000000000
    x8: 0x0000000104b48660   x9: 0x00000001f65fffe9  x10: 0x0000000270336561  x11: 0x000000000000003f
   x12: 0x0000000000000029  x13: 0x0000000283a97c80  x14: 0x00000001ab5dc000  x15: 0x0000000105c5e088
   x16: 0x00000001ab78e4c0  x17: 0x575b0001057c81ac  x18: 0x0000000000000000  x19: 0x0000000000000000
   x20: 0x0000600001f68820  x21: 0x0000600000be73c0  x22: 0x0000000154e4e3a0  x23: 0x00000001f5cdf983
   x24: 0x0000000000000000  x25: 0x000060000154c4e0  x26: 0x000000002bd80025  x27: 0x0000000000000000
   x28: 0x00000000000000fc   fp: 0x000000016b67ee70   lr: 0x00000001057c81d8
    sp: 0x000000016b67ee60   pc: 0x00000001057c81dc cpsr: 0x20001000
   far: 0x0000000000000008  esr: 0x92000006 (Data Abort) byte read Translation fault

Binary Images:
       0x1057b0000 -        0x105c17fff co.gitup.kit (*) <5fa9665f-5ca0-34ff-81da-42df255f5ff8> /Users/USER/*/GitUp.app/Contents/Frameworks/GitUpKit.framework/Versions/A/GitUpKit
       0x1ae4f9000 -        0x1af3b1fff com.apple.AppKit (6.9) <143e26e2-b101-34d6-8111-94ca9e06daef> /System/Library/Frameworks/AppKit.framework/Versions/C/AppKit
       0x104ad0000 -        0x104b2ffff dyld (*) <f0564ec5-bf9c-3107-82b3-485f927b489f> /usr/lib/dyld
       0x1ab8c9000 -        0x1ab900fff libsystem_kernel.dylib (*) <b71e7783-80bc-36bb-af5d-579344d68742> /usr/lib/system/libsystem_kernel.dylib
       0x1ab950000 -        0x1abe96fff com.apple.CoreFoundation (6.9) <fc3c193d-0cdb-3569-9f0e-bd2507ca1dbb> /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation
       0x1ab901000 -        0x1ab90dfff libsystem_pthread.dylib (*) <63c4eef9-69a5-38b1-996e-8d31b66a051d> /usr/lib/system/libsystem_pthread.dylib
               0x0 - 0xffffffffffffffff ??? (*) <00000000-0000-0000-0000-000000000000> ???

External Modification Summary:
  Calls made by other processes targeting this process:
    task_for_pid: 0
    thread_create: 0
    thread_set_state: 0
  Calls made by this process:
    task_for_pid: 0
    thread_create: 0
    thread_set_state: 0
  Calls made by all processes on this machine:
    task_for_pid: 0
    thread_create: 0
    thread_set_state: 0

VM Region Summary:
ReadOnly portion of Libraries: Total=1.0G resident=0K(0%) swapped_out_or_unallocated=1.0G(100%)
Writable regions: Total=2.5G written=0K(0%) resident=0K(0%) swapped_out=0K(0%) unallocated=2.5G(100%)

                                VIRTUAL   REGION 
REGION TYPE                        SIZE    COUNT (non-coalesced) 
===========                     =======  ======= 
Accelerate framework              1920K       15 
Activity Tracing                   256K        1 
CG backing stores                 4032K        4 
CG image                          10.7M      121 
CG raster data                     144K        2 
ColorSync                          640K       28 
CoreAnimation                    512.8M      730 
CoreGraphics                        32K        2 
CoreImage                           64K        4 
CoreUI image data                 6176K       53 
Foundation                          64K        2 
Image IO                          1008K        9 
Kernel Alloc Once                   32K        1 
MALLOC                           581.0M      103 
MALLOC guard page                  288K       15 
MALLOC_MEDIUM (reserved)           1.0G       10         reserved VM address space (unallocated)
MALLOC_NANO (reserved)           384.0M        1         reserved VM address space (unallocated)
SQLite page cache                   64K        1 
STACK GUARD                       56.1M        6 
Stack                             10.6M        6 
VM_ALLOCATE                       3024K      104 
__AUTH                            2551K      310 
__AUTH_CONST                      19.9M      502 
__CTF                               756        1 
__DATA                            15.1M      497 
__DATA_CONST                      18.1M      513 
__DATA_DIRTY                      1751K      212 
__FONT_DATA                          4K        1 
__LINKEDIT                       579.2M       10 
__OBJC_CONST                      3465K      279 
__OBJC_RO                         83.0M        1 
__OBJC_RW                         3168K        1 
__TEXT                           491.4M      531 
__UNICODE                          592K        1 
dyld private memory               1024K        1 
libnetwork                         128K        8 
mapped file                      792.3M      278 
shared memory                      976K       19 
===========                     =======  ======= 
TOTAL                              4.5G     4383 
TOTAL, minus reserved VM space     3.1G     4383 



-----------
Full Report
-----------

{"app_name":"GitUp","timestamp":"2022-12-14 18:31:45.00 -0500","app_version":"1.3.4","slice_uuid":"c3c5302f-c0e1-3a2c-9a61-e5fe43d853ce","build_version":"1047","platform":1,"bundleID":"co.gitup.mac","share_with_app_devs":1,"is_first_party":0,"bug_type":"309","os_version":"macOS 12.6.2 (21G320)","incident_id":"7CF79CD3-1B3B-4105-BC32-E7AD4C7BCDE7","name":"GitUp"}
{
  "uptime" : 25000,
  "procLaunch" : "2022-12-14 09:43:18.1235 -0500",
  "procRole" : "Foreground",
  "version" : 2,
  "userID" : 501,
  "deployVersion" : 210,
  "modelCode" : "MacBookPro18,1",
  "procStartAbsTime" : 57845783176,
  "coalitionID" : 2145,
  "osVersion" : {
    "train" : "macOS 12.6.2",
    "build" : "21G320",
    "releaseType" : "User"
  },
  "captureTime" : "2022-12-14 18:31:43.7627 -0500",
  "incident" : "7CF79CD3-1B3B-4105-BC32-E7AD4C7BCDE7",
  "bug_type" : "309",
  "pid" : 3807,
  "procExitAbsTime" : 623793521943,
  "translated" : false,
  "cpuType" : "ARM-64",
  "procName" : "GitUp",
  "procPath" : "\/Users\/USER\/*\/GitUp.app\/Contents\/MacOS\/GitUp",
  "bundleInfo" : {"CFBundleShortVersionString":"1.3.4","CFBundleVersion":"1047","CFBundleIdentifier":"co.gitup.mac"},
  "storeInfo" : {"deviceIdentifierForVendor":"0F4BD1F1-9A4A-55D8-9DCE-EAEA5CB32F46","thirdParty":true},
  "parentProc" : "launchd",
  "parentPid" : 1,
  "coalitionName" : "co.gitup.mac",
  "crashReporterKey" : "6E4510AB-47F3-73CF-21DB-07A64B26A4A3",
  "wakeTime" : 2735,
  "sleepWakeUUID" : "595B35F4-A7CA-49FD-9B16-E749F59927DE",
  "sip" : "enabled",
  "vmRegionInfo" : "0x8 is not in any region.  Bytes before following region: 105553518919672\n      REGION TYPE                    START - END         [ VSIZE] PRT\/MAX SHRMOD  REGION DETAIL\n      UNUSED SPACE AT START\n--->  \n      MALLOC_NANO (reserved)   600018000000-600020000000 [128.0M] rw-\/rwx SM=NUL  ...(unallocated)",
  "isCorpse" : 1,
  "exception" : {"codes":"0x0000000000000001, 0x0000000000000008","rawCodes":[1,8],"type":"EXC_BAD_ACCESS","signal":"SIGSEGV","subtype":"KERN_INVALID_ADDRESS at 0x0000000000000008"},
  "termination" : {"flags":0,"code":11,"namespace":"SIGNAL","indicator":"Segmentation fault: 11","byProc":"exc handler","byPid":3807},
  "vmregioninfo" : "0x8 is not in any region.  Bytes before following region: 105553518919672\n      REGION TYPE                    START - END         [ VSIZE] PRT\/MAX SHRMOD  REGION DETAIL\n      UNUSED SPACE AT START\n--->  \n      MALLOC_NANO (reserved)   600018000000-600020000000 [128.0M] rw-\/rwx SM=NUL  ...(unallocated)",
  "extMods" : {"caller":{"thread_create":0,"thread_set_state":0,"task_for_pid":0},"system":{"thread_create":0,"thread_set_state":0,"task_for_pid":0},"targeted":{"thread_create":0,"thread_set_state":0,"task_for_pid":0},"warnings":0},
  "faultingThread" : 0,
  "threads" : [{"triggered":true,"id":64844,"threadState":{"x":[{"value":105553149200416},{"value":8428453865,"objc-selector":"isEqualToObject:"},{"value":0},{"value":5746897904},{"value":16},{"value":6096940008},{"value":1},{"value":0},{"value":4373907040,"symbolLocation":224,"symbol":"_main_thread"},{"value":8428453865,"objc-selector":"isEqualToObject:"},{"value":10472351073},{"value":63},{"value":41},{"value":10798857344},{"value":7170015232},{"value":4391821448,"symbolLocation":0,"symbol":"OBJC_CLASS_$_GCHistoryCommit"},{"value":7171794112,"symbolLocation":0,"symbol":"objc_retain"},{"value":6294624908567413164,"symbolLocation":6294624904180400128,"symbol":"-[GCObject(Extensions) isEqualToObject:]"},{"value":0},{"value":0},{"value":105553149200416},{"value":105553128747968},{"value":5719253920},{"value":8418883971,"objc-selector":"keyDown:"},{"value":0},{"value":105553138599136},{"value":735576101},{"value":0},{"value":252}],"flavor":"ARM_THREAD_STATE64","lr":{"value":4387013080},"cpsr":{"value":536875008},"fp":{"value":6096940656},"sp":{"value":6096940640},"esr":{"value":2449473542,"description":"(Data Abort) byte read Translation fault"},"pc":{"value":4387013084,"matchesCrashFrame":1},"far":{"value":8}},"queue":"com.apple.main-thread","frames":[{"imageOffset":98780,"symbol":"-[GCObject(Extensions) isEqualToObject:]","symbolLocation":48,"imageIndex":0},{"imageOffset":98776,"symbol":"-[GCObject(Extensions) isEqualToObject:]","symbolLocation":44,"imageIndex":0},{"imageOffset":372144,"symbol":"-[GCLiveRepository(Utilities) validateCheckoutCommit:]","symbolLocation":140,"imageIndex":0},{"imageOffset":369180,"symbol":"-[GCLiveRepository(Utilities) smartCheckoutCommit:window:]","symbolLocation":76,"imageIndex":0},{"imageOffset":342308,"symbol":"-[GICommitListViewController smartCheckoutSelectedCommit]","symbolLocation":108,"imageIndex":0},{"imageOffset":342404,"symbol":"-[GICommitListViewController keyDown:]","symbolLocation":52,"imageIndex":0},{"imageOffset":2326996,"symbol":"forwardMethod","symbolLocation":200,"imageIndex":1},{"imageOffset":2326996,"symbol":"forwardMethod","symbolLocation":200,"imageIndex":1},{"imageOffset":2326996,"symbol":"forwardMethod","symbolLocation":200,"imageIndex":1},{"imageOffset":2326996,"symbol":"forwardMethod","symbolLocation":200,"imageIndex":1},{"imageOffset":3795860,"symbol":"-[NSControl keyDown:]","symbolLocation":124,"imageIndex":1},{"imageOffset":3875628,"symbol":"-[NSTableView keyDown:]","symbolLocation":1000,"imageIndex":1},{"imageOffset":285004,"symbol":"-[GITableView keyDown:]","symbolLocation":136,"imageIndex":0},{"imageOffset":1781384,"symbol":"-[NSWindow(NSEventRouting) _reallySendEvent:isDelayedEvent:]","symbolLocation":5908,"imageIndex":1},{"imageOffset":1774860,"symbol":"-[NSWindow(NSEventRouting) sendEvent:]","symbolLocation":348,"imageIndex":1},{"imageOffset":332424,"symbol":"-[GIWindow sendEvent:]","symbolLocation":228,"imageIndex":0},{"imageOffset":1770676,"symbol":"-[NSApplication(NSEvent) sendEvent:]","symbolLocation":2780,"imageIndex":1},{"imageOffset":4628724,"symbol":"-[NSApplication _handleEvent:]","symbolLocation":76,"imageIndex":1},{"imageOffset":204808,"symbol":"-[NSApplication run]","symbolLocation":636,"imageIndex":1},{"imageOffset":14076,"symbol":"NSApplicationMain","symbolLocation":1132,"imageIndex":1},{"imageOffset":20620,"symbol":"start","symbolLocation":520,"imageIndex":2}]},{"id":64920,"name":"com.apple.NSEventThread","frames":[{"imageOffset":6320,"symbol":"mach_msg_trap","symbolLocation":8,"imageIndex":3},{"imageOffset":7456,"symbol":"mach_msg","symbolLocation":76,"imageIndex":3},{"imageOffset":545296,"symbol":"__CFRunLoopServiceMachPort","symbolLocation":372,"imageIndex":4},{"imageOffset":538304,"symbol":"__CFRunLoopRun","symbolLocation":1180,"imageIndex":4},{"imageOffset":535172,"symbol":"CFRunLoopRunSpecific","symbolLocation":600,"imageIndex":4},{"imageOffset":1761536,"symbol":"_NSEventThread","symbolLocation":196,"imageIndex":1},{"imageOffset":29292,"symbol":"_pthread_start","symbolLocation":148,"imageIndex":5},{"imageOffset":8332,"symbol":"thread_start","symbolLocation":8,"imageIndex":5}]},{"id":503932,"frames":[{"imageOffset":8312,"symbol":"start_wqthread","symbolLocation":0,"imageIndex":5}]},{"id":504195,"frames":[{"imageOffset":8312,"symbol":"start_wqthread","symbolLocation":0,"imageIndex":5}]},{"id":504196,"frames":[{"imageOffset":8312,"symbol":"start_wqthread","symbolLocation":0,"imageIndex":5}]},{"id":504712,"frames":[{"imageOffset":8312,"symbol":"start_wqthread","symbolLocation":0,"imageIndex":5}]}],
  "usedImages" : [
  {
    "source" : "P",
    "arch" : "arm64",
    "base" : 4386914304,
    "CFBundleIdentifier" : "co.gitup.kit",
    "size" : 4620288,
    "uuid" : "5fa9665f-5ca0-34ff-81da-42df255f5ff8",
    "path" : "\/Users\/USER\/*\/GitUp.app\/Contents\/Frameworks\/GitUpKit.framework\/Versions\/A\/GitUpKit",
    "name" : "GitUpKit"
  },
  {
    "source" : "P",
    "arch" : "arm64e",
    "base" : 7219417088,
    "CFBundleShortVersionString" : "6.9",
    "CFBundleIdentifier" : "com.apple.AppKit",
    "size" : 15437824,
    "uuid" : "143e26e2-b101-34d6-8111-94ca9e06daef",
    "path" : "\/System\/Library\/Frameworks\/AppKit.framework\/Versions\/C\/AppKit",
    "name" : "AppKit",
    "CFBundleVersion" : "2113.60.148"
  },
  {
    "source" : "P",
    "arch" : "arm64e",
    "base" : 4373413888,
    "size" : 393216,
    "uuid" : "f0564ec5-bf9c-3107-82b3-485f927b489f",
    "path" : "\/usr\/lib\/dyld",
    "name" : "dyld"
  },
  {
    "source" : "P",
    "arch" : "arm64e",
    "base" : 7173083136,
    "size" : 229376,
    "uuid" : "b71e7783-80bc-36bb-af5d-579344d68742",
    "path" : "\/usr\/lib\/system\/libsystem_kernel.dylib",
    "name" : "libsystem_kernel.dylib"
  },
  {
    "source" : "P",
    "arch" : "arm64e",
    "base" : 7173636096,
    "CFBundleShortVersionString" : "6.9",
    "CFBundleIdentifier" : "com.apple.CoreFoundation",
    "size" : 5533696,
    "uuid" : "fc3c193d-0cdb-3569-9f0e-bd2507ca1dbb",
    "path" : "\/System\/Library\/Frameworks\/CoreFoundation.framework\/Versions\/A\/CoreFoundation",
    "name" : "CoreFoundation",
    "CFBundleVersion" : "1866"
  },
  {
    "source" : "P",
    "arch" : "arm64e",
    "base" : 7173312512,
    "size" : 53248,
    "uuid" : "63c4eef9-69a5-38b1-996e-8d31b66a051d",
    "path" : "\/usr\/lib\/system\/libsystem_pthread.dylib",
    "name" : "libsystem_pthread.dylib"
  },
  {
    "size" : 0,
    "source" : "A",
    "base" : 0,
    "uuid" : "00000000-0000-0000-0000-000000000000"
  }
],
  "sharedCache" : {
  "base" : 7170015232,
  "size" : 3144761344,
  "uuid" : "be7fe6ad-4560-3ae2-883e-432f78b45062"
},
  "vmSummary" : "ReadOnly portion of Libraries: Total=1.0G resident=0K(0%) swapped_out_or_unallocated=1.0G(100%)\nWritable regions: Total=2.5G written=0K(0%) resident=0K(0%) swapped_out=0K(0%) unallocated=2.5G(100%)\n\n                                VIRTUAL   REGION \nREGION TYPE                        SIZE    COUNT (non-coalesced) \n===========                     =======  ======= \nAccelerate framework              1920K       15 \nActivity Tracing                   256K        1 \nCG backing stores                 4032K        4 \nCG image                          10.7M      121 \nCG raster data                     144K        2 \nColorSync                          640K       28 \nCoreAnimation                    512.8M      730 \nCoreGraphics                        32K        2 \nCoreImage                           64K        4 \nCoreUI image data                 6176K       53 \nFoundation                          64K        2 \nImage IO                          1008K        9 \nKernel Alloc Once                   32K        1 \nMALLOC                           581.0M      103 \nMALLOC guard page                  288K       15 \nMALLOC_MEDIUM (reserved)           1.0G       10         reserved VM address space (unallocated)\nMALLOC_NANO (reserved)           384.0M        1         reserved VM address space (unallocated)\nSQLite page cache                   64K        1 \nSTACK GUARD                       56.1M        6 \nStack                             10.6M        6 \nVM_ALLOCATE                       3024K      104 \n__AUTH                            2551K      310 \n__AUTH_CONST                      19.9M      502 \n__CTF                               756        1 \n__DATA                            15.1M      497 \n__DATA_CONST                      18.1M      513 \n__DATA_DIRTY                      1751K      212 \n__FONT_DATA                          4K        1 \n__LINKEDIT                       579.2M       10 \n__OBJC_CONST                      3465K      279 \n__OBJC_RO                         83.0M        1 \n__OBJC_RW                         3168K        1 \n__TEXT                           491.4M      531 \n__UNICODE                          592K        1 \ndyld private memory               1024K        1 \nlibnetwork                         128K        8 \nmapped file                      792.3M      278 \nshared memory                      976K       19 \n===========                     =======  ======= \nTOTAL                              4.5G     4383 \nTOTAL, minus reserved VM space     3.1G     4383 \n",
  "legacyInfo" : {
  "threadTriggered" : {
    "queue" : "com.apple.main-thread"
  }
},
  "trialInfo" : {
  "rollouts" : [
    {
      "rolloutId" : "5fc94383418129005b4e9ae0",
      "factorPackIds" : {

      },
      "deploymentId" : 240000551
    },
    {
      "rolloutId" : "61301e3a61217b3110231469",
      "factorPackIds" : {
        "SIRI_FIND_MY_CONFIGURATION_FILES" : "6348493aa52bb16adc4e4d06"
      },
      "deploymentId" : 240000021
    }
  ],
  "experiments" : [

  ]
}
}

Model: MacBookPro18,1, BootROM 8419.60.44, proc 10:8:2 processors, 32 GB, SMC 
Graphics: Apple M1 Pro, Apple M1 Pro, Built-In
Display: Color LCD, 3456 x 2234 Retina, Main, MirrorOff, Online
Memory Module: LPDDR5
AirPort: Wi-Fi, wl0: Apr  6 2022 05:55:54 version 20.90.45.0.8.7.118 FWID 01-e7138ff2
Bluetooth: Version (null), 0 services, 0 devices, 0 incoming serial ports
Network Service: Wi-Fi, AirPort, en0
USB Device: USB31Bus
USB Device: USB31Bus
USB Device: USB31Bus
Thunderbolt Bus: MacBook Pro, Apple Inc.
Thunderbolt Bus: MacBook Pro, Apple Inc.
Thunderbolt Bus: MacBook Pro, Apple Inc.

The text was updated successfully, but these errors were encountered:

lucasderraugh · 2022-12-16T01:14:54Z

Think I've seen this in earlier builds as well. I want to say hitting return too many times when searching is what causes it for me.

When we apply a search result (hit return on one), this triggers a change that ultimately deselects all items in the search table view. This means we still have first responder status but have nothing selected. If we hit return now we will try and validate a nil commit and we can't compare nil commits. The solution is to verify that we have a valid commit selection. Fixes #883

…ted (#884) When we apply a search result (hit return on one), this triggers a change that ultimately deselects all items in the search table view. This means we still have first responder status but have nothing selected. If we hit return now we will try and validate a nil commit and we can't compare nil commits. The solution is to verify that we have a valid commit selection. Fixes #883

lucasderraugh changed the title ~~Crash in 1.3.4~~ Crash when hitting return multiple times on a search result Dec 16, 2022

lucasderraugh changed the title ~~Crash when hitting return multiple times on a search result~~ Crash when hitting return in search results when nothing is selected Dec 16, 2022

lucasderraugh self-assigned this Dec 16, 2022

lucasderraugh mentioned this issue Dec 16, 2022

Fix crash when hitting return in search results when nothing is selected #884

Merged

lucasderraugh closed this as completed in #884 Dec 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Crash when hitting return in search results when nothing is selected #883

Crash when hitting return in search results when nothing is selected #883

ghost commented Dec 14, 2022

lucasderraugh commented Dec 16, 2022

Crash when hitting return in search results when nothing is selected #883

Crash when hitting return in search results when nothing is selected #883

Comments

ghost commented Dec 14, 2022

lucasderraugh commented Dec 16, 2022