Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when hitting return in search results when nothing is selected #884

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

lucasderraugh
Copy link
Collaborator

When we apply a search result (hit return on one), this triggers a change that ultimately deselects all items in the search table view. This means we still have first responder status but have nothing selected. If we hit return now we will try and validate a nil commit and we can't compare nil commits. The solution is to verify that we have a valid commit selection.

Fixes #883

When we apply a search result (hit return on one), this triggers a change that ultimately deselects all items in the search table view.
This means we still have first responder status but have nothing selected. If we hit return now we will try and validate a nil commit and we can't compare nil commits. The solution is to verify that we have a valid commit selection.

Fixes #883
@lucasderraugh lucasderraugh merged commit 16adf50 into master Dec 16, 2022
@lucasderraugh lucasderraugh deleted the lderraugh/883 branch September 12, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Crash when hitting return in search results when nothing is selected
1 participant