Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring. MRC removal. Part one. #827

Merged
merged 6 commits into from
Aug 15, 2022

Conversation

lolgear
Copy link
Contributor

@lolgear lolgear commented May 28, 2022

This PR is the first PR in series of MRC removal PRs.

It removes MRC from

  • GILine
  • GILayer
  • GIBranch
  • GCCommitDatabase


#define GC_POINTER_LIST_FOR_LOOP(name, type, variable) \
type variable; \
GC_POINTER_LIST_FOR_LOOP_VARIABLE(name, variable)
type variable = (__bridge type)GC_POINTER_LIST_GET(name, 0); \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to use __bridge casting to adapt ARC rules.

Copy link
Collaborator

@lucasderraugh lucasderraugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few requested changes, but other than that looks good to me.

GitUpKit/Core/GCCommitDatabase.m Outdated Show resolved Hide resolved
GitUpKit/Interface/GILine.m Outdated Show resolved Hide resolved
@lolgear lolgear force-pushed the refactoring/mrc_removal_part_one branch from bbfdd4f to 9dacad6 Compare August 15, 2022 16:51
@lucasderraugh lucasderraugh merged commit 9282c9b into git-up:master Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants