-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring. MRC removal. Part one. #827
Merged
lucasderraugh
merged 6 commits into
git-up:master
from
lolgear:refactoring/mrc_removal_part_one
Aug 15, 2022
Merged
Refactoring. MRC removal. Part one. #827
lucasderraugh
merged 6 commits into
git-up:master
from
lolgear:refactoring/mrc_removal_part_one
Aug 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolgear
commented
May 28, 2022
|
||
#define GC_POINTER_LIST_FOR_LOOP(name, type, variable) \ | ||
type variable; \ | ||
GC_POINTER_LIST_FOR_LOOP_VARIABLE(name, variable) | ||
type variable = (__bridge type)GC_POINTER_LIST_GET(name, 0); \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to use __bridge casting to adapt ARC rules.
lucasderraugh
requested changes
Aug 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few requested changes, but other than that looks good to me.
lolgear
force-pushed
the
refactoring/mrc_removal_part_one
branch
from
August 15, 2022 16:51
bbfdd4f
to
9dacad6
Compare
lucasderraugh
added a commit
that referenced
this pull request
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first PR in series of MRC removal PRs.
It removes MRC from