Refactoring. MRC removal. Part two. #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasderraugh
requested changes
Aug 21, 2022
GitUpKit/Core/GCRepository+Reflog.m
Outdated
| [_messages release]; | ||
|
|
||
| [super dealloc]; | ||
| _fromSHA1 = nil; |
There was a problem hiding this comment.
Let's remove all the nil assignments. It's just extra code that doesn't need to be there. Please apply this suggestion to everywhere in this PR. Thanks!
There was a problem hiding this comment.
@lucasderraugh
Fixed.
Could you also comment on #858?
And I noticed that you merged your own PR with new libgit2.
Can we now check and merge File history PR?
lolgear
force-pushed
the
refactoring/mrc_removal_part_two
branch
from
90c4cdd to
3ad5757
Compare
|
@lucasderraugh |
lucasderraugh
approved these changes
Nov 3, 2022
lucasderraugh
added a commit
that referenced
this pull request
Dec 13, 2022
lucasderraugh
added a commit
that referenced
this pull request
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is second PR in series of MRC removal PRs.
Part one. #827
This PR removes MRC from