-
-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning for users visiting Grants page #5988
Add warning for users visiting Grants page #5988
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5988 +/- ##
==========================================
+ Coverage 28.86% 28.89% +0.02%
==========================================
Files 270 270
Lines 23742 23742
Branches 3454 3454
==========================================
+ Hits 6854 6860 +6
+ Misses 16615 16609 -6
Partials 273 273
Continue to review full report at Codecov.
|
This would probably be most effective on the /fund page when users are about to contribute to grant and the grant creation page (/grants/new) What do you think on restricting the alert to just those pages? a quick google led me to this |
@thelostone-mc Showing the warning on But as I mentioned on the issue page, Brave browser doesn't seem to provide a Brave-specific And since Brave Wallet is a fork of MetaMask, the So it seems displaying the warning only for Brave users by detecting Brave Browser or Brave Wallet is hard. The answer in the stackoverflow question also says:
|
@sebastiantf let's do it that way ! Danke :D |
@thelostone-mc Shall I change the warning from |
72d3aa2
to
2617a23
Compare
@thelostone-mc Please check my new commits and review this PR. I have changed the warning from |
@sebastiantf Looks good ^_^ |
Description
Adds a warning for users about using Brave Wallet and MetaMask while visiting
https://gitcoin.co/grants
Refers/Fixes
Fixes: #5865
Testing
No issues on eslint and stylelint.