fix: prevents bigNumber overflow #9862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdixon
requested review from
chibie,
frankchen07,
nutrina,
PixelantDesign and
thelostone-mc
as code owners
thelostone-mc
added a commit
that referenced
this pull request
Dec 10, 2021
* fix: apply the cap after normalising the distribution (#9846) * fix: apply the cap after normalising the distribution * fix: adds flag to estimate_clr so that we can skip saving the results * fix: expose id and title to make it easier to compare results * fix: apply Adityas comments * add logging * add more logs * add logging * fix: adds id to totals * fix: clean up logs * fix: ensures we dont spread the remainder if we havent reached the saturation point * fix: debug output Co-authored-by: Aditya Anand M C <aditya.anandmc@gmail.com> * fix: enable search in GrantCLRCalculation admin * fix: ensures props are available for str of questAttempt * fix: prevents bigNumber overflow (#9862) * fix: linting issues Co-authored-by: Graham Dixon <graham@gitcoin.co> Co-authored-by: Graham Dixon <graham@gdixon.co.uk>
thelostone-mc
added a commit
that referenced
this pull request
Dec 14, 2021
* fix: apply the cap after normalising the distribution (#9846) * fix: apply the cap after normalising the distribution * fix: adds flag to estimate_clr so that we can skip saving the results * fix: expose id and title to make it easier to compare results * fix: apply Adityas comments * add logging * add more logs * add logging * fix: adds id to totals * fix: clean up logs * fix: ensures we dont spread the remainder if we havent reached the saturation point * fix: debug output Co-authored-by: Aditya Anand M C <aditya.anandmc@gmail.com> * fix: enable search in GrantCLRCalculation admin * fix: ensures props are available for str of questAttempt * fix: prevents bigNumber overflow (#9862) * allow disabling checkout via admin Co-authored-by: Graham Dixon <graham@gitcoin.co> Co-authored-by: Graham Dixon <graham@gdixon.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will ensure that wallets which contain a large number of tokens will not throw a bigNumber overflow error
Refers/Fixes
Fixes: #9854
Testing
Tested locally