Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stable -> master #9873

Merged
merged 5 commits into from
Dec 10, 2021
Merged

stable -> master #9873

merged 5 commits into from
Dec 10, 2021

Conversation

thelostone-mc
Copy link
Member

Description

Getting master ahead of stable

gdixon and others added 4 commits December 8, 2021 15:17
* fix: apply the cap after normalising the distribution

* fix: adds flag to estimate_clr so that we can skip saving the results

* fix: expose id and title to make it easier to compare results

* fix: apply Adityas comments

* add logging

* add more logs

* add logging

* fix: adds id to totals

* fix: clean up logs

* fix: ensures we dont spread the remainder if we havent reached the saturation point

* fix: debug output

Co-authored-by: Aditya Anand M C <aditya.anandmc@gmail.com>
Copy link
Contributor

@nutrina nutrina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gdixon gdixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This PR is passing tests, but the branch isn't (it needs the fixes we have in master to be merged in!)

@thelostone-mc thelostone-mc merged commit 2ee18ca into master Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants