Add instrumentation to detection and classification #2162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tes in the payload.
Instrument all calls and pass the blob, strategy and language candidates in the payload.
arfon
added a commit
that referenced
this pull request
Mar 5, 2015
Add instrumentation to detection and classification
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds instrumentation to Linguist's language detection and bayesian classification.
The idea is that applications pulling in Linguist can set
Linguist.instrumentertoActiveSupport::Notifications(or whatever instrumentation service they're using) to receive instrumentation details whenever Linguist performs a detection or classification.cc @bkeepers @vmg