Add repository model tests #97
Conversation
Testing RepositoryModel creation via the path constructor implies hitting libgit2sharp codepaths, and libgit2sharp doesn't expose nice interfaces for testing (why??). So, move things around and add a GitService that replaces the extension methods that depend on libgit2sharp, so we can at least mock at a higher level. The things that require this GitService are not created via mef, so expose it via the Services static class.
There was a problem hiding this comment.
This got moved up to VSExtensions 'cause it makes sense there.
The prior code always created a `IGitService` instance, but we only need to create them if there are any active repositories. Also changed to use `.Any()` because it is more expressive.
Also we should prefer to use `var` unless the type's really not clear at all from the right hand side. Also, I prefer all the usings on top and not within namespaces.
I documented all the methods.
There was a problem hiding this comment.
@shana: So according to R#, there is no type in the solution that inherits from both EnvDTE.DTE and EnvDTE80.DTE2. That leads me to believe that the Dte2 property is always null. Also, I can't find any usages of the Dte2 property. Do we need this?
There was a problem hiding this comment.
Oh, don't believe everything R# says. These are COM interfaces, the cast is
It's going to be used in the future, so I keep it around, along with some other handy magical vs types (that are all probably used now, but weren't in the beginning).
|
🍍 |
|
@shana: If you're ok with my changes, this is good to merge. The only outstanding question is the |
|
@haacked Changes look 👍! |
|
✨ |
2 participants
This PR is based on #79, so that one should be merged first before looking at this.
Add repository model tests and support for testing things that rely on the GetUri and GetRepo extension methods that use libgit2#.
Testing RepositoryModel creation via the path constructor implies hitting libgit2sharp codepaths, and libgit2sharp doesn't expose nice interfaces for testing (why??). So, move things around and add a
GitService that replaces the extension methods that depend on libgit2sharp, so we can at least mock at a higher level.
The things that require this GitService are not created via mef, so expose it via the Services static class.