This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Caching the UIProvider #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shana
force-pushed
the
shana/uiprovider-caching
branch
from
419f35f to
6ef6caa
Compare
There was a problem hiding this comment.
What's with the double cast?
There was a problem hiding this comment.
The type system doesn't know that it's the same type at compile time inside this condition 😉
|
✨ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #79 and #97, those need to be merged first before this one.
The IUIProvider service provides access to everything else, no point in doing a lookup every time we need to access it manually (not via mef constructors)