Add array findlast and findlastindex #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithamus
force-pushed
the
add-array-findlast-and-findlastindex
branch
from
243a1c2
to
ad429db
Compare
mattcosta7
approved these changes
Jun 22, 2023
iansan5653
approved these changes
Jun 22, 2023
dgreif
previously approved these changes
Jun 23, 2023
|
Do we need to add these to |
|
yep |
dgreif
approved these changes
Jun 23, 2023
|
@dgreif i don’t have merge privileges so you’ll need to do the honours please. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34
This is a big diff because it upgrades typescript, I can pull that out in a separate PR if we deem it worthwhile.