Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct off by 1 error in findLast polyfills #39

Merged
merged 1 commit into from
Aug 14, 2023
Merged

correct off by 1 error in findLast polyfills #39

merged 1 commit into from
Aug 14, 2023

Conversation

kintner
Copy link
Contributor

@kintner kintner commented Aug 14, 2023

This corrects the off by one error in the Array.findLast and Array.findLastIndex polyfills from #35

@kintner kintner requested a review from a team as a code owner August 14, 2023 18:46
@kintner kintner requested a review from jfuchs August 14, 2023 18:46
@kintner kintner merged commit dc2fbdb into main Aug 14, 2023
2 checks passed
@kintner kintner deleted the kintner/offby1 branch August 14, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srt32 srt32 srt32 approved these changes

@jfuchs jfuchs Awaiting requested review from jfuchs jfuchs is a code owner automatically assigned from github/web-systems-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kintner @srt32