check-approval: Fix missing license_ids variable #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wking
force-pushed
the
check-approval-license-ids
branch
from
f845adf
to
d2ed77d
Compare
Avoid: $ ./script/check-approval MIT ./script/check-approval:55:in `<main>': undefined local variable or method `license_ids' for main:Object (NameError) The license_ids line was added in e505eb8 (check if license is aleady a license, 2016-01-18, github#318), but license_ids was removed from the helper in b99e7ab (replace 'id' variables with 'spdx_lcase' to minimize confusion, 2016-06-01, github#424). This commit restores the old code locally, since this script is the only consumer.
wking
force-pushed
the
check-approval-license-ids
branch
from
d2ed77d
to
45369ac
Compare
|
I personally don't think it's worth the effort and potential disruption of anyone else working on branch to force push when picking up updates. But it seems to be part of your workflow, so go ahead. Thanks for the contributions! Here and to the various license meta projects you are so steadfastly improving. 👍 |
Ah, sorry. I thought it would help folks in the future by avoiding backwards merges, when we could rebase to accomplish the same thing. I'll let the backwards merges go in the future ;). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid:
The
license_idsline was added in e505eb8 (#318), butlicense_idswas removed from the helper in b99e7ab (#424). This commit restores the old code locally, since this script is the only consumer.