spec_helper: Extract FSF approval from wking.github.io/fsf-api #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wking
commented
Jan 3, 2018
|
|
||
| # FSF approved the Clear BSD, but doesn't use its SPDX ID or Name | ||
| if licenses.keys.include? 'clearbsd' | ||
| licenses['bsd-3-clause-clear'] = licenses['clearbsd'] |
There was a problem hiding this comment.
To help with review, this rename is handled in the mock API:
$ curl -s https://wking.github.io/fsf-api/clearbsd.json | jq .identifiers.spdx
[
"BSD-3-Clause-Clear"
]The MIT / Expat and other mappings are also handled in the mock API.
Ideally the FSF would be maintaining the API (or any API), but until
someone can talk them into that I think we can save work by
collaborating on the mock API. Using a JSON API also allows us to
drop the Nokogiri dependency.
The parens feel excessive, and I'm not familiar with Ruby, so they
might be. However, removing the parens from the libre check resulted
in:
$ ./script/check-approval ISC
./script/check-approval:8:in `require_relative': /.../choosealicense.com/spec/spec_helper.rb:108: syntax error, unexpected tSTRING_BEG, expecting keyword_then or ';' or '\n' (SyntaxError)
...gs') && meta['tags'].include? 'libre'
... ^
/.../choosealicense.com/spec/spec_helper.rb:116: syntax error, unexpected keyword_end, expecting end-of-input
from ./script/check-approval:8:in `<main>'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally the FSF would be maintaining the API (or any API), but until someone can talk them into that I think we can save work by collaborating on the mock API (discussion in #561). Using a JSON API also allows us to drop the Nokogiri dependency.
The parens feel excessive, and I'm not familiar with Ruby, so they might be. However, removing the parens from the libre check resulted in:
If you want to test with
./script/check-approval ISCand similar, you should merge #567 and #568 to fix unrelatedcheck-approvalissues.Fixes #561.