Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec_helper: Extract FSF approval from wking.github.io/fsf-api #569

Merged
merged 1 commit into from
Jan 3, 2018

Commits on Jan 3, 2018

  1. spec_helper: Extract FSF approval from wking.github.io/fsf-api

    Ideally the FSF would be maintaining the API (or any API), but until
    someone can talk them into that I think we can save work by
    collaborating on the mock API.  Using a JSON API also allows us to
    drop the Nokogiri dependency.
    
    The parens feel excessive, and I'm not familiar with Ruby, so they
    might be.  However, removing the parens from the libre check resulted
    in:
    
      $ ./script/check-approval ISC
      ./script/check-approval:8:in `require_relative': /.../choosealicense.com/spec/spec_helper.rb:108: syntax error, unexpected tSTRING_BEG, expecting keyword_then or ';' or '\n' (SyntaxError)
      ...gs') && meta['tags'].include? 'libre'
      ...                               ^
      /.../choosealicense.com/spec/spec_helper.rb:116: syntax error, unexpected keyword_end, expecting end-of-input
              from ./script/check-approval:8:in `<main>'
    wking committed Jan 3, 2018
    Configuration menu
    Copy the full SHA
    84a7bbb View commit details
    Browse the repository at this point in the history