Fix sourcepos, add missing extension tests and add sourcepos tests #223
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #222. This PR:
Quality assurance:
make test
passingmake leakcheck
is passing.CMARK_OPT_SOURCEPOS
is set, I've tried to set and unset this flag for parser only (not for the renderer), by hardcoding this incmark_parser_new_with_mem
. In both cases, all tests pass except for a few tests failing on sourcepos mismatch (which was expected).Performance - I wasn't able to measure any difference:
CMARK_OPT_SOURCEPOS
was hardcoded incmark_parser_new_with_mem
:I'd be glad if this is going to be fixed, as we now have to maintain own fork with fixed cmark-gfm and a our fork of commonmarker.
And any feedback would be welcome!