Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform specific bundle #240

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Platform specific bundle #240

merged 1 commit into from
Oct 1, 2020

Conversation

marcogario
Copy link
Contributor

@marcogario marcogario commented Sep 30, 2020

Download the platform specific bundle. These bundles are generated via the split workflow https://github.com/github/codeql-action/blob/main/.github/workflows/split.yml

If the tool url is provided, we will still respect that. However, in other cases we download codeql-bundle-${platform}.tar.gz

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

@marcogario marcogario force-pushed the marcogario/platform-bundle branch from b10805b to 4792b31 Compare October 1, 2020 07:59
@marcogario marcogario force-pushed the marcogario/platform-bundle branch from 4792b31 to d5029a8 Compare October 1, 2020 08:04
@marcogario marcogario marked this pull request as ready for review October 1, 2020 08:27
Copy link
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is all good. I've checked that it still uses a pinned version from the environment in preference to downloading the platform specific pack. And it still uses a user-supplied download URL if given.

As noted in person earlier, this now relies on all the platform specific versions being present. But this will be true for dotcom, and I believe you checked that the sync tool copies all artefacts. So this requirement should be fine.

@marcogario
Copy link
Contributor Author

As noted in person earlier, this now relies on all the platform specific versions being present. But this will be true for dotcom, and I believe you checked that the sync tool copies all artefacts. So this requirement should be fine.

Yes, this is worth underlying one more time: the platform bundles are now a requirement.

Indeed, I did verify that the sync tool supports this, and did also update the bundle release process accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants