Merge main into v1 #252
Merged
Merge main into v1 #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Update Python scripts for "Python deps setup"
As we move towards analysing the merge commit for pull requests by default, we should stop sending `/refs/pull/n/head` rather than `refs/pull/n/merge` _unless_ the checked-out SHA has actually changed. Here we assume that any change (compared to GITHUB_SHA) indicates that `git checkout HEAD^2` has been run earlier. This may sometimes be incorrect (e.g. `git checkout mybranch`), but in that case the ref would be wrong either way.
Co-authored-by: Marco Gario <marcogario@github.com>
Resolve violations of no-throw-literal lint
Resolve violations of no-useless-escape lint
Do not always overwrite the GITHUB_REF for PRs
Platform specific bundle
Resolve violations of sort-imports lint
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Bumps [@actions/core](https://github.com/actions/toolkit/tree/HEAD/packages/core) from 1.2.0 to 1.2.6. - [Release notes](https://github.com/actions/toolkit/releases) - [Changelog](https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md) - [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/core) Signed-off-by: dependabot[bot] <support@github.com>
…ore-1.2.6 Bump @actions/core from 1.2.0 to 1.2.6
Updating the format slightly to match [the docs](https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows#schedule) precisely
README: document cron fields in example
Python deps setup
aibaars
previously requested changes
Oct 5, 2020
aibaars
reviewed
Oct 5, 2020
There was a problem hiding this comment.
Having the python scripts in the Action instead of the CodeQL bundle makes it possible to iterate more quickly to make improvements. This is a good reason in the short term. In the long run there is an increased risk of compatibility issues between the Action and the CodeQL python pack. Luckily, the automatic installation feature may not be needed in the future as the Python team is working on improving things such that having the dependencies installed would no longer be needed.
We know this is not the best solution, but is just a quick patch for unblocking this use case until the python extractor can manage the dependencies by itself and we could just drop all this process |
|
Spoke to @aibaars - these comments are no longer gating |
cbraynor
approved these changes
Oct 5, 2020
simon-engledew
added a commit
that referenced
this pull request
Dec 2, 2020
commit 1dd265a Merge: 4dcb320 c3a9325 Author: Simon Engledew <simon-engledew@github.com> Date: Wed Dec 2 08:31:48 2020 +0000 Merge pull request #333 from github/simon-engledew/hide-warnings-v1 Hide a warning that is confusing on GHES commit c3a9325 Author: Simon Engledew <simon-engledew@github.com> Date: Tue Dec 1 16:54:23 2020 +0000 Hide an warning that is confusing on GHES commit 4dcb320 Merge: 577fc45 b15854c Author: David Verdeguer <47184891+Daverlo@users.noreply.github.com> Date: Mon Nov 23 15:01:13 2020 +0100 Merge pull request #317 from github/update-v1-b15854c9 Merge main into v1 commit 577fc45 Merge: 1de54f1 d4eb1e3 Author: Robert <robertbrignull@github.com> Date: Mon Nov 16 12:03:04 2020 +0000 Merge pull request #306 from github/update-v1-d4eb1e36 Merge main into v1 commit 1de54f1 Merge: e3bfd25 4b301bd Author: Robin Neatherway <rneatherway@github.com> Date: Mon Nov 9 15:42:20 2020 +0000 Merge pull request #295 from github/main Update v1 with new CodeQL bundle commit e3bfd25 Merge: 935dd40 f13bd45 Author: Simon Engledew <simon-engledew@github.com> Date: Mon Nov 9 10:22:41 2020 +0000 Merge pull request #293 from github/update-v1-f13bd452 Merge main into v1 commit 935dd40 Merge: 253ef42 9a0139e Author: David Verdeguer <47184891+Daverlo@users.noreply.github.com> Date: Tue Nov 3 11:27:07 2020 +0100 Merge pull request #286 from github/update-v1-9a0139ee Merge main into v1 commit 253ef42 Merge: 7507a5a 46110c3 Author: David Verdeguer <47184891+Daverlo@users.noreply.github.com> Date: Wed Oct 28 11:38:54 2020 +0100 Merge pull request #279 from github/update-v1-46110c36 Merge main into v1 commit 7507a5a Merge: 4a27006 c8b8c04 Author: Robin Neatherway <rneatherway@github.com> Date: Mon Oct 19 12:38:26 2020 +0100 Merge pull request #269 from github/update-v1-c8b8c041 Merge main into v1 commit 4a27006 Merge: 5dc2db0 b1e2c9b Author: Marco Gario <marcogario@github.com> Date: Wed Oct 7 13:31:57 2020 +0200 Merge pull request #256 from github/update-v1-b1e2c9b8 Merge main into v1 commit 5dc2db0 Merge: 8ea621e a1fc3a5 Author: Chris Raynor <cbraynor@github.com> Date: Mon Oct 5 16:29:49 2020 +0100 Merge pull request #252 from github/update-v1-a1fc3a5e Merge main into v1 commit 8ea621e Merge: c7c948a f2e557e Author: Robert <robertbrignull@github.com> Date: Tue Sep 29 10:34:59 2020 +0100 Merge pull request #234 from github/update-v1-f2e557e7 Merge main into v1 commit c7c948a Merge: f6894d6 b2dfa6e Author: Robert <robertbrignull@github.com> Date: Mon Sep 21 11:04:47 2020 +0100 Merge pull request #224 from github/update-v1-b2dfa6e6 Merge main into v1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging a1fc3a5 into v1
Conductor for this PR is @cbraynor
Contains the following pull requests: