Add tests for config-utils #36
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for the
config-utils
file. This does change the behaviour in a couple of minor cases, but largely this PR is trying to just assert the current behaviour.I'm not a huge fan of the fact that we silently ignore invalid yaml fields in certain cases. I'd prefer it if we always threw an error, but I didn't want to make that change here. If we decide to do that in the future then I'd feel much happier having tests of this functionality.
A side note, I had to add the
--serial
flag when running the tests to stop running them in parallel. My understanding (according to the docs) is that tests from separate files are run in separate nodejs processes, but tests within a file are run in one process. Therefore since we are messing with process environment variables in order to control our code we need to run tests serially and avoid parallelism.Merge / deployment checklist