Report exceptions during upload #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Error is just an alert that changed line. |
|
❤️ Thanks for taking this over @robertbrignull ! |
robertbrignull
force-pushed
the
always-report-exceptions-v2
branch
from
e7f8768 to
6db8182
Compare
|
@sampart would you be able to review this? |
sampart
approved these changes
Jun 8, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm taking over #22 from @joshhale as he's too busy right now. I had a hard time fixing the merge conflicts so I've decided to make a new pull request. This has the benefit that you can still see the old PR and check that it does the same as this one.
I recommend comparing the diff for this pull request to #22. The only difference should be in
config-utils.tswhere the change had already been made by #36.@Daverlo can you review this?
Merge / deployment checklist