Skip to content

"Make a contribution" button vs. includes #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jidanni opened this issue Nov 5, 2020 · 3 comments · Fixed by #1895
Closed

"Make a contribution" button vs. includes #1094

jidanni opened this issue Nov 5, 2020 · 3 comments · Fixed by #1895
Assignees
Labels
ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team

Comments

@jidanni
Copy link

jidanni commented Nov 5, 2020

In #1093 we see the user (me) saw a problem in
https://docs.github.com/en/free-pro-team@latest/rest/reference/activity
and pressed "Make a contribution", leading to
https://github.com/github/docs/edit/main/content/rest/reference/activity.md
however, due to includes, was not able to find the text he intended to
edit. Nor did https://github.com/github/docs/search?q=last_read_at find
it. So he gave up and asked others to make the edit for him.
Probably the file containing "last_read_at" is located off site or something.
(Not in https://github.com/github/docs/tree/main/includes or
https://github.com/github/docs at all. According to Search.)

@jidanni jidanni added the engineering Will involve Docs Engineering label Nov 5, 2020
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 5, 2020
@janiceilene
Copy link
Contributor

👋 Thanks for opening an issue @jidanni! That definitely seems like a frustrating experience. Are there any particular changes that could improve it?

@jidanni
Copy link
Author

jidanni commented Nov 7, 2020

Mmmm, just have the UX team follow each step I listed and see what needs to be fixed.
P.S., I never did find where you folks put the file.

@janiceilene
Copy link
Contributor

Thanks @jidanni! I'm going to triage this to the ecosystem team for now. I think the first thing we should do is add something to the contributing.md and maybe the readme.md explaining how these generated docs work.

@janiceilene janiceilene added ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team and removed engineering Will involve Docs Engineering labels Nov 9, 2020
@lucascosti lucascosti self-assigned this Dec 8, 2020
@lucascosti lucascosti removed the triage Do not begin working on this issue until triaged by the team label Dec 8, 2020
jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this issue Oct 6, 2022
Co-authored-by: Lana Brindley <github@lanabrindley.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants