Skip to content

Add READMEs for API content directories #1895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 10, 2020
Merged

Conversation

lucascosti
Copy link
Contributor

@lucascosti lucascosti commented Dec 8, 2020

Closes: #1094

Why:

It's not clear to contributors that the reference content for the REST and GraphQL APIs are generated from the API source internally within GitHub, and as a result we can't accept contributions for them in this repository.

What's being changed:

Added READMEs to both the REST and GraphQL content directories to explain their structure and that the reference content is generated using includes.

Previews:

Check off the following:

  • All of the tests are passing.
  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

Copy link
Contributor

@rachmari rachmari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucascosti the README pages are ignored, so adding these shouldn't affect the docs site. I added a few suggestions, but no blockers. 🚢

lucascosti and others added 3 commits December 9, 2020 11:17
@lucascosti
Copy link
Contributor Author

Thanks for confirming, @rachmari! ❤️

This should be ready to merge :shipit:

@lucascosti lucascosti added the ready to merge This pull request is ready to merge label Dec 9, 2020
@lucascosti lucascosti merged commit 1588f50 into main Dec 10, 2020
@lucascosti lucascosti deleted the lucascosti/add-api-readmes branch December 10, 2020 03:31
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Make a contribution" button vs. includes
2 participants