Skip to content

Example ghe-config command to exempt users from rate limiting has a typo. #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
galaxyeden opened this issue Nov 12, 2020 · 6 comments · Fixed by #1279
Closed

Example ghe-config command to exempt users from rate limiting has a typo. #1280

galaxyeden opened this issue Nov 12, 2020 · 6 comments · Fixed by #1279

Comments

@galaxyeden
Copy link
Contributor

What article on docs.github.com is affected?

Command-line utilities

What part(s) of the article would you like to see updated?

The following example:

$ ghe-config app.github.rate_limiting_exempt_users "hubot github-actions"
# Exempts the users hubot and github-actions from rate limits

In this example, the correct key has hyphens, not underscores. Therefore it should read:

$ ghe-config app.github.rate-limiting-exempt-users "hubot github-actions"
# Exempts the users hubot and github-actions from rate limits

Additional information

I've opened PR #1279 for this.
@welcome
Copy link

welcome bot commented Nov 12, 2020

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 12, 2020
@galaxyeden galaxyeden mentioned this issue Nov 12, 2020
Merged
4 tasks
@jh8787

This comment has been minimized.

Sign in to view
@janiceilene
Copy link
Contributor

janiceilene commented Nov 16, 2020 •
edited
Loading

Thanks for opening a PR @GalaxyAllie!

@timchepeleff
Copy link
Contributor

Just wanted to drop a note that I ran into an issue here. PR contained the solution - would love to see this get merged/reflected in the official docs!

@janiceilene
Copy link
Contributor

Thanks for letting us know @timchepeleff! Looks like the PR is waiting on a review and then we'll get it fixed up ⚡

@janiceilene janiceilene removed the triage Do not begin working on this issue until triaged by the team label Nov 20, 2020
@shati-patel
Copy link
Contributor

Fixed by #1279 - the change will be live shortly 😃

@shati-patel shati-patel linked a pull request Nov 20, 2020 that will close this issue
Fixes typo in key app.github.rate-limiting-exempt-users #1279
Merged
4 tasks
This was referenced Jul 1, 2021
Open
Open
jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this issue Oct 6, 2022
@charislam @Loquacity
[Cloud multi-node] Add new approval steps (github#1280)
f5d6560 
Co-authored-by: Lana Brindley <github@lanabrindley.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes typo in key app.github.rate-limiting-exempt-users github/docs
5 participants
@timchepeleff @janiceilene @galaxyeden @shati-patel @jh8787