Skip to content

Fixes typo in key app.github.rate-limiting-exempt-users #1279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 20, 2020
Merged

Fixes typo in key app.github.rate-limiting-exempt-users #1279

merged 2 commits into from
Nov 20, 2020

Conversation

galaxyeden
Copy link
Contributor

@galaxyeden galaxyeden commented Nov 12, 2020 •
edited
Loading

Why:

This fixes issue #1280

What's being changed:

Changes app.github.rate_limiting_exempt_users to app.github.rate-limiting-exempt-users to reflect the correct key.

Check off the following:

@galaxyeden galaxyeden added the bug An error or flaw that causes unintended or unexpected results label Nov 12, 2020
@galaxyeden galaxyeden mentioned this pull request Nov 12, 2020
Closed
@janiceilene
Copy link
Contributor

@GalaxyAllie Thanks so much for opening a PR! I'll get this triaged for review ✨

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Nov 16, 2020
@shati-patel shati-patel self-assigned this Nov 20, 2020
shati-patel
shati-patel approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix @GalaxyAllie! 🎉 We'll get this merged shortly 🚢

@shati-patel shati-patel merged commit f6f6b64 into main Nov 20, 2020
@shati-patel shati-patel deleted the GalaxyAllie-patch-1 branch November 20, 2020 19:15
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@shati-patel shati-patel linked an issue Nov 20, 2020 that may be closed by this pull request
Example ghe-config command to exempt users from rate limiting has a typo. #1280
Closed
This was referenced Jul 14, 2021
Open
Open
@snyk-bot snyk-bot mentioned this pull request Aug 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shati-patel shati-patel shati-patel approved these changes

Assignees

@shati-patel shati-patel

Labels
bug An error or flaw that causes unintended or unexpected results content This issue or pull request belongs to the Docs Content team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Example ghe-config command to exempt users from rate limiting has a typo.
4 participants
@galaxyeden @janiceilene @shati-patel @persiannet