test: add comprehensive coverage for TOCTOU fix error paths#768
Closed
Copilot wants to merge 2 commits intofix/ssl-bump-race-conditionfrom
Closed
test: add comprehensive coverage for TOCTOU fix error paths#768Copilot wants to merge 2 commits intofix/ssl-bump-race-conditionfrom
Copilot wants to merge 2 commits intofix/ssl-bump-race-conditionfrom
Conversation
3 tasks
Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix TOCTOU race conditions in ssl-bump.ts
test: add comprehensive coverage for TOCTOU fix error paths
Feb 12, 2026
Collaborator
|
Closing PR in favor of tracking issue #837. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TOCTOU fix in PR #766 introduced error handling branches that reduced
ssl-bump.tsbranch coverage from 100% to 81.25%, failing the coverage regression check.Changes
generateSessionCa(string rejection handling)prefer-promise-reject-with-error→@typescript-eslint/prefer-promise-reject-errorsCoverage
ssl-bump.ts: 81.25% → 100% branch coverageThe tests use filesystem permissions to trigger realistic error conditions:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.