fix: correct exit code success detection in test runner

[Claude]

The "Test Chroot Package Managers" workflow was failing with a paradoxical error: "Expected awf to succeed, but it failed with exit code 0". The test runner in awf-runner.ts was mishandling undefined exit codes from execa.

Root Cause

When execa returns undefined for exitCode, the code was creating a mismatch:

// Buggy logic
return {
  exitCode: result.exitCode || 0,    // → 0 when undefined
  success: result.exitCode === 0,    // → false (undefined === 0)
}

This caused exitCode: 0 but success: false, making passing tests appear as failures.

Changes

• Normalize exit code once using nullish coalescing (??) before using it for both fields
• Applied fix to both run() and runWithSudo() methods in tests/fixtures/awf-runner.ts

// Fixed logic
const exitCode = result.exitCode ?? 0;
return {
  exitCode,
  success: exitCode === 0,
}

The rustc test was actually passing; the test framework was incorrectly reporting it as failed.

[Copilot]

Pull request overview

Fixes inconsistent success detection in the AwfRunner test fixture when execa returns an undefined exitCode, which could yield exitCode: 0 while incorrectly reporting success: false and fail workflows like “Test Chroot Package Managers”.

Changes:

• Normalize exitCode once via const exitCode = result.exitCode ?? 0 in run().
• Apply the same normalization in runWithSudo().
• Use the normalized exitCode for both the returned exitCode and success fields to keep them consistent.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.