fix: add Rust installation step when runtime specified in workflow#794
Conversation
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b8ba875
into
claude/extract-rust-one-shot-token-lib
Smoke Test ResultsLast 2 Merged PRs:
Test Results:
Status: PASS cc:
|
Bun Build Test Results
Overall: PASS ✅ All tests completed successfully!
|
Node.js Build Test Results
Overall: PASS ✅ All three Node.js projects successfully installed dependencies and passed their test suites.
|
Deno Build Test Results
Overall: ✅ PASS All Deno tests completed successfully.
|
Go Build Test Results
Overall: PASS ✅ All Go projects successfully downloaded dependencies and passed their test suites.
|
|
Smoke Test Results Last 2 merged PRs:
✅ GitHub MCP - PR list retrieved Status: PASS
|
.NET Build Test ResultsAll .NET projects built and ran successfully! ✅
Overall: PASS Project Outputshello-world:
|
* Initial plan * feat: add rust one-shot-token library implementation Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> * docs: update README for rust implementation Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> * feat: update Dockerfile and entrypoint for rust build Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> * fix(security): use multi-stage build for rust compilation Use official rust:1.77-slim Docker image in multi-stage build to avoid executing unverified rustup installer script. This mitigates supply chain attack risk during container builds. Changes: - Add rust-builder stage using rust:1.77-slim official image - Build one-shot-token library in isolated builder stage - Copy pre-built library to main stage via COPY --from=rust-builder - Remove curl/build-essential from main stage (no longer needed) - Add security comments documenting supply chain attack mitigation Addresses security review recommendation from @lpcox. Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> * feat(ci): add crates.io to build-test-rust network allowlist * chore(ci): regenerate build-test-rust lock file with crates.io Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> * fix: correct exit code success detection in test runner (#793) * Initial plan * fix: correct exit code success detection in test runner The awf-runner was incorrectly handling undefined exit codes from execa. When exitCode was undefined, it would set exitCode field to 0 (via || operator) but success field would evaluate undefined === 0 which is false. This caused tests to fail with the confusing message: "Expected awf to succeed, but it failed with exit code 0" Fixed by normalizing exitCode to a variable first using ?? operator, then using that normalized value for both fields. Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> --------- Co-authored-by: anthropic-code-agent[bot] <242468646+Claude@users.noreply.github.com> Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> * Initial plan (#794) Co-authored-by: anthropic-code-agent[bot] <242468646+Claude@users.noreply.github.com> * fix: add Rust toolchain setup and RUSTUP_HOME support for chroot package manager tests (#797) * Initial plan * fix: add explicit toolchain to rust setup in test workflow Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> * feat: add RUSTUP_HOME environment variable support for Rust toolchain Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> --------- Co-authored-by: anthropic-code-agent[bot] <242468646+Claude@users.noreply.github.com> Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> --------- Co-authored-by: anthropic-code-agent[bot] <242468646+Claude@users.noreply.github.com> Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
The workflow compiler ignores
runtimes.rustspecification, causing Cargo commands to fail. Agent times out after 30 minutes attempting to execute non-existent toolchain.Root Cause
Workflow definition specifies:
Compiled workflow skips from "Install awf dependencies" directly to "Download container images" with no Rust installation step. Network configuration and test repository structure are correct.
Required Fix
Workflow compiler must generate Rust installation step when
runtimes.rustis present:Step must be inserted before agent execution. Firewall already permits
sh.rustup.rsandstatic.rust-lang.org.Evidence
Mossaka/gh-aw-firewall-test-rust: valid structure withfd/andzoxide/Cargo projectssh.rustup.rs,static.rust-lang.org,crates.io,index.crates.io,static.crates.ioWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/github/gh-aw-firewall/actions/jobs/63474444819/usr/bin/gh gh run view 21971662629 --job 63474444819 --log de/node/bin/git(http block)https://api.github.com/repos/github/gh-aw-firewall/actions/runs/21971662629/artifacts/usr/bin/curl curl -s -H Authorization: token REDACTED(http block)If you need me to access, download, or install something from one of these locations, you can either: