Add path traversal validation to playground snapshot downloads #10002
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix security alert in fetch-playground-snapshots.mjs
Security Issue
Line 589 writes user-controlled data from external source (
file.namefrom GitHub API) to local file system without explicit validation at point of use.Plan
path.basename()to prevent path traversal attacksChanges Made
fetchFromContentsApi (line 589): Added three-layer security validation:
path.basename()to strip any directory componentsfetchFromActionsApi (line 662): Applied same security measures for consistency
Code formatting: Applied prettier formatting to docs/scripts .mjs files for consistency
Security Improvements
path.basename()strips directory components like../../../etc/Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.