[WIP] Cache frontmatter on field to reduce redundant lookups

pkg/workflow/compiler_orchestrator_workflow.go

@@ -329,7 +329,7 @@ func (c *Compiler) extractAdditionalConfigurations(
 	workflowData.RepoMemoryConfig = repoMemoryConfig
 
 	// Extract and process safe-inputs and safe-outputs
-	workflowData.Command, workflowData.CommandEvents = c.extractCommandConfig(frontmatter)
+	workflowData.Command, workflowData.CommandEvents = c.extractCommandConfig(frontmatter, workflowData)
 	workflowData.Jobs = c.extractJobsFromFrontmatter(frontmatter)
 	workflowData.Roles = c.extractRoles(frontmatter)
 	workflowData.Bots = c.extractBots(frontmatter)

pkg/workflow/compiler_safe_outputs.go

@@ -154,7 +154,7 @@ func (c *Compiler) parseOnSection(frontmatter map[string]any, workflowData *Work
 			// Post-process YAML to ensure cron expressions are quoted
 			yamlStr = parser.QuoteCronExpressions(yamlStr)
 			// Apply comment processing to filter fields (draft, forks, names)
-			yamlStr = c.commentOutProcessedFieldsInOnSection(yamlStr, frontmatter)
+			yamlStr = c.commentOutProcessedFieldsInOnSection(yamlStr, frontmatter, workflowData)
 			// Add zizmor ignore comment if workflow_run trigger is present
 			yamlStr = c.addZizmorIgnoreForWorkflowRun(yamlStr)
 			// Keep "on" quoted as it's a YAML boolean keyword

pkg/workflow/data/action_pins.json

@@ -30,6 +30,11 @@
       "version": "v5",
       "sha": "93cb6efe18208431cddfb8368fd83d5badbf9bfd"
     },
+    "actions/checkout@v6": {
+      "repo": "actions/checkout",
+      "version": "v6",
+      "sha": "8e8c483db84b4bee98b60c0593521ed34d9990e8"
+    },
     "actions/checkout@v6.0.2": {
       "repo": "actions/checkout",
       "version": "v6.0.2",

pkg/workflow/error_message_quality_test.go

@@ -28,7 +28,7 @@ func TestErrorMessageQuality(t *testing.T) {
 						"manual-approval": 123, // Wrong type
 					},
 				}
-				_, err := c.extractManualApprovalFromOn(frontmatter)
+				_, err := c.extractManualApprovalFromOn(frontmatter, nil)
 				return err
 			},
 			shouldContain: []string{
@@ -45,7 +45,7 @@ func TestErrorMessageQuality(t *testing.T) {
 				frontmatter := map[string]any{
 					"on": []string{"invalid"}, // Wrong type
 				}
-				_, err := c.extractManualApprovalFromOn(frontmatter)
+				_, err := c.extractManualApprovalFromOn(frontmatter, nil)
 				return err
 			},
 			shouldContain: []string{

pkg/workflow/frontmatter_extraction_yaml.go

@@ -124,12 +124,22 @@ func (c *Compiler) extractTopLevelYAMLSection(frontmatter map[string]any, key st
 // commentOutProcessedFieldsInOnSection comments out draft, fork, forks, names, manual-approval, stop-after, skip-if-match, skip-if-no-match, reaction, and lock-for-agent fields in the on section
 // These fields are processed separately and should be commented for documentation
 // Exception: names fields in sections with __gh_aw_native_label_filter__ marker in frontmatter are NOT commented out
-func (c *Compiler) commentOutProcessedFieldsInOnSection(yamlStr string, frontmatter map[string]any) string {
+func (c *Compiler) commentOutProcessedFieldsInOnSection(yamlStr string, frontmatter map[string]any, workflowData ...*WorkflowData) string {
 	frontmatterLog.Print("Processing 'on' section to comment out processed fields")
 
+	// Use cached On field from ParsedFrontmatter if available (when workflowData is provided)
+	var onValue any
+	var exists bool
+	if len(workflowData) > 0 && workflowData[0] != nil && workflowData[0].ParsedFrontmatter != nil && workflowData[0].ParsedFrontmatter.On != nil {
+		onValue = workflowData[0].ParsedFrontmatter.On
+		exists = true
+	} else {
+		onValue, exists = frontmatter["on"]
+	}
+
 	// Check frontmatter for native label filter markers
 	nativeLabelFilterSections := make(map[string]bool)
-	if onValue, exists := frontmatter["on"]; exists {
+	if exists {
 		if onMap, ok := onValue.(map[string]any); ok {
 			for _, sectionKey := range []string{"issues", "pull_request", "discussion", "issue_comment"} {
 				if sectionValue, hasSec := onMap[sectionKey]; hasSec {
@@ -507,10 +517,20 @@ func (c *Compiler) extractExpressionFromIfString(ifString string) string {
 }
 
 // extractCommandConfig extracts command configuration from frontmatter including name and events
-func (c *Compiler) extractCommandConfig(frontmatter map[string]any) (commandNames []string, commandEvents []string) {
+func (c *Compiler) extractCommandConfig(frontmatter map[string]any, workflowData ...*WorkflowData) (commandNames []string, commandEvents []string) {
+	// Use cached On field from ParsedFrontmatter if available (when workflowData is provided)
+	var onValue any
+	var exists bool
+	if len(workflowData) > 0 && workflowData[0] != nil && workflowData[0].ParsedFrontmatter != nil && workflowData[0].ParsedFrontmatter.On != nil {
+		onValue = workflowData[0].ParsedFrontmatter.On
+		exists = true
+	} else {
+		onValue, exists = frontmatter["on"]
+	}
+
 	// Check new format: on.slash_command or on.slash_command.name (preferred)
 	// Also check legacy format: on.command or on.command.name (deprecated)
-	if onValue, exists := frontmatter["on"]; exists {
+	if exists {
 		if onMap, ok := onValue.(map[string]any); ok {
 			var commandValue any
 			var hasCommand bool

pkg/workflow/manual_approval.go

@@ -9,8 +9,17 @@ import (
 var manualApprovalLog = logger.New("workflow:manual_approval")
 
 // extractManualApprovalFromOn extracts the manual-approval value from the on: section
-func (c *Compiler) extractManualApprovalFromOn(frontmatter map[string]any) (string, error) {
-	onSection, exists := frontmatter["on"]
+func (c *Compiler) extractManualApprovalFromOn(frontmatter map[string]any, workflowData *WorkflowData) (string, error) {
+	// Use cached On field from ParsedFrontmatter if available, otherwise fall back to map access
+	var onSection any
+	var exists bool
+	if workflowData != nil && workflowData.ParsedFrontmatter != nil && workflowData.ParsedFrontmatter.On != nil {
+		onSection = workflowData.ParsedFrontmatter.On
+		exists = true
+	} else {
+		onSection, exists = frontmatter["on"]
+	}
+
 	if !exists {
 		manualApprovalLog.Print("No on: section found in frontmatter")
 		return "", nil
@@ -42,8 +51,8 @@ func (c *Compiler) extractManualApprovalFromOn(frontmatter map[string]any) (stri
 func (c *Compiler) processManualApprovalConfiguration(frontmatter map[string]any, workflowData *WorkflowData) error {
 	manualApprovalLog.Print("Processing manual-approval configuration")
 
-	// Extract manual-approval from the on: section
-	manualApproval, err := c.extractManualApprovalFromOn(frontmatter)
+	// Extract manual-approval from the on: section (uses cached ParsedFrontmatter.On if available)
+	manualApproval, err := c.extractManualApprovalFromOn(frontmatter, workflowData)
 	if err != nil {
 		manualApprovalLog.Printf("Failed to extract manual-approval: %v", err)
 		return err

pkg/workflow/manual_approval_test.go

@@ -69,7 +69,7 @@ func TestExtractManualApprovalFromOn(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			c := &Compiler{}
-			got, err := c.extractManualApprovalFromOn(tt.frontmatter)
+			got, err := c.extractManualApprovalFromOn(tt.frontmatter, nil)
 			if (err != nil) != tt.wantErr {
 				t.Errorf("extractManualApprovalFromOn() error = %v, wantErr %v", err, tt.wantErr)
 				return