Fix custom agent name references in log parser tests#12649
Conversation
…tic-workflows Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…tic-workflows Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
🛡️ Security Posture AnalysisThis PR contains changes that affect the security posture. Please review the following concern: 🟠 Network Boundary Expansion: JSR (JavaScript Registry) Domain AddedLocation: Multiple workflow files (22 Change Detected: - --allow-domains api.business.githubcopilot.com,...,npmjs.com,npmjs.org,...
+ --allow-domains '*.jsr.io,api.business.githubcopilot.com,...,jsr.io,...,npmjs.com,npmjs.org,...'Security Impact: This change expands the network boundary by adding:
The JSR (JavaScript Registry) domains are being added to the firewall allowlists across all sandboxed workflows. While JSR is a legitimate JavaScript package registry, this represents a network boundary expansion that:
Affected Workflows:
Recommendation:
Summary
Note: This is an automated security analysis. The JSR domains may be a legitimate addition for Deno/modern JavaScript tooling support. However, since this change is not mentioned in the PR description and uses a wildcard pattern, it warrants explicit review and justification from the PR author or maintainers.
|
JavaScript tests were referencing
create-agentic-workflowanddebug-agentic-workflowas custom agent names. These are prompt file names in.github/aw/, not agents. The actual custom agent isagentic-workflows(dispatcher in.github/agents/).Changes
actions/setup/js/log_parser_shared.test.cjscreate-agentic-workflow→agentic-workflowsdebug-agentic-workflow→agentic-campaign-designerContext
Custom agents are
.agent.mdfiles in.github/agents/:agentic-workflows.agent.md- dispatcher that routes to specialized promptsagentic-campaign-designer.agent.md- campaign design agentPrompt files are
.mdfiles in.github/aw/:create-agentic-workflow.md- creation prompt (not an agent)debug-agentic-workflow.md- debug prompt (not an agent)Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
telemetry.astro.build/opt/hostedtoolcache/node/24.13.0/x64/bin/node node /home/REDACTED/work/gh-aw/gh-aw/docs/node_modules/.bin/astro build git conf�� user.email test@example.com /usr/bin/git --write scripts/**/*.js 64/bin/go git init�� 64/bin/go go /usr/bin/git -json GO111MODULE layTitle git(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.