[code-simplifier] refactor: extract setStringFromMap helper in parseMessagesConfig

[github-actions]

The parseMessagesConfig function in pkg/workflow/safe_outputs_config_messages.go had 12 identical 4-line blocks for parsing string fields from a map[string]any. This PR extracts a setStringFromMap helper function to eliminate the repetition while preserving identical behavior.

Files Simplified

• pkg/workflow/safe_outputs_config_messages.go — extracted setStringFromMap helper; reduced parseMessagesConfig from ~100 to ~50 lines

Improvements Made

Reduced Repetition

Before, each string field required 4 lines:

if footer, exists := messagesMap["footer"]; exists {
    if footerStr, ok := footer.(string); ok {
        config.Footer = footerStr
    }
}

After, each string field is one line:

setStringFromMap(messagesMap, "footer", &config.Footer)

Applied Project Standards

• Helper function is small, focused, and well-commented
• All 12 string field assignments now use the helper consistently
• The boolean field (append-only-comments) retains its own block since it has a log statement and a different type

Changes Based On

Recent changes from:

• Fix safe-outputs message parsing and schema gaps for detection-failure and agent-failure-* #17207 — Fix safe-outputs message parsing and schema gaps for detection-failure (added 3 new string fields using the same pattern)

Testing

• ✅ File is gofmt-compliant (gofmt -l produces no output)
• ✅ go vet passes (no compile errors or type issues)
• ✅ No functional changes — behavior is identical; only the structure changed

Review Focus

Please verify:

• All 12 string fields are still correctly mapped to their YAML keys
• The boolean append-only-comments field is still handled separately (it has a debug log call)
• No unintended side effects

---

Automated by Code Simplifier Agent — analyzing code from the last 24 hours

Generated by Code Simplifier

Warning

⚠️ Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• proxy.golang.org

• expires on Feb 21, 2026, 7:08 PM UTC

[Copilot]

Pull request overview

Refactors parseMessagesConfig to remove repeated “read string from map and assign” blocks by introducing a small helper, aiming to preserve existing parsing behavior.

Changes:

• Added setStringFromMap helper to DRY up string-field extraction from map[string]any
• Updated parseMessagesConfig to use the helper for all string message fields
• Kept append-only-comments parsing as a dedicated bool block (with logging)

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

parseMessagesConfig now sets detection-failure, agent-failure-issue, and agent-failure-comment via the new helper, but the existing TestParseMessagesConfig assertions (in pkg/workflow/safe_outputs_test.go) don’t cover these fields (or append-only-comments). Adding/expanding tests to assert these mappings would help catch accidental key/field mixups during refactors like this.