Skip to content

[code-simplifier] refactor: extract setStringFromMap helper in parseMessagesConfig #17258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 1 commit into from
Feb 20, 2026
Merged

[code-simplifier] refactor: extract setStringFromMap helper in parseMessagesConfig #17258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 21 additions & 71 deletions pkg/workflow/safe_outputs_config_messages.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,15 @@ var safeOutputMessagesLog = logger.New("workflow:safe_outputs_config_messages")
// Safe Output Messages Configuration
// ========================================

// setStringFromMap reads m[key] and assigns its string value to *dest if found.
func setStringFromMap(m map[string]any, key string, dest *string) {
if val, exists := m[key]; exists {
if str, ok := val.(string); ok {
*dest = str
}
}
}

// parseMessagesConfig parses the messages configuration from safe-outputs frontmatter
func parseMessagesConfig(messagesMap map[string]any) *SafeOutputMessagesConfig {
safeOutputMessagesLog.Printf("Parsing messages configuration with %d fields", len(messagesMap))
Expand All @@ -25,77 +34,18 @@ func parseMessagesConfig(messagesMap map[string]any) *SafeOutputMessagesConfig {
}
}

if footer, exists := messagesMap["footer"]; exists {
if footerStr, ok := footer.(string); ok {
config.Footer = footerStr
}
}

if footerInstall, exists := messagesMap["footer-install"]; exists {
if footerInstallStr, ok := footerInstall.(string); ok {
config.FooterInstall = footerInstallStr
}
}

if footerWorkflowRecompile, exists := messagesMap["footer-workflow-recompile"]; exists {
if footerWorkflowRecompileStr, ok := footerWorkflowRecompile.(string); ok {
config.FooterWorkflowRecompile = footerWorkflowRecompileStr
}
}

if footerWorkflowRecompileComment, exists := messagesMap["footer-workflow-recompile-comment"]; exists {
if footerWorkflowRecompileCommentStr, ok := footerWorkflowRecompileComment.(string); ok {
config.FooterWorkflowRecompileComment = footerWorkflowRecompileCommentStr
}
}

if stagedTitle, exists := messagesMap["staged-title"]; exists {
if stagedTitleStr, ok := stagedTitle.(string); ok {
config.StagedTitle = stagedTitleStr
}
}

if stagedDescription, exists := messagesMap["staged-description"]; exists {
if stagedDescriptionStr, ok := stagedDescription.(string); ok {
config.StagedDescription = stagedDescriptionStr
}
}

if runStarted, exists := messagesMap["run-started"]; exists {
if runStartedStr, ok := runStarted.(string); ok {
config.RunStarted = runStartedStr
}
}

if runSuccess, exists := messagesMap["run-success"]; exists {
if runSuccessStr, ok := runSuccess.(string); ok {
config.RunSuccess = runSuccessStr
}
}

if runFailure, exists := messagesMap["run-failure"]; exists {
if runFailureStr, ok := runFailure.(string); ok {
config.RunFailure = runFailureStr
}
}

if detectionFailure, exists := messagesMap["detection-failure"]; exists {
if detectionFailureStr, ok := detectionFailure.(string); ok {
config.DetectionFailure = detectionFailureStr
}
}

if agentFailureIssue, exists := messagesMap["agent-failure-issue"]; exists {
if agentFailureIssueStr, ok := agentFailureIssue.(string); ok {
config.AgentFailureIssue = agentFailureIssueStr
}
}

if agentFailureComment, exists := messagesMap["agent-failure-comment"]; exists {
if agentFailureCommentStr, ok := agentFailureComment.(string); ok {
config.AgentFailureComment = agentFailureCommentStr
}
}
setStringFromMap(messagesMap, "footer", &config.Footer)
setStringFromMap(messagesMap, "footer-install", &config.FooterInstall)
setStringFromMap(messagesMap, "footer-workflow-recompile", &config.FooterWorkflowRecompile)
setStringFromMap(messagesMap, "footer-workflow-recompile-comment", &config.FooterWorkflowRecompileComment)
setStringFromMap(messagesMap, "staged-title", &config.StagedTitle)
setStringFromMap(messagesMap, "staged-description", &config.StagedDescription)
setStringFromMap(messagesMap, "run-started", &config.RunStarted)
setStringFromMap(messagesMap, "run-success", &config.RunSuccess)
setStringFromMap(messagesMap, "run-failure", &config.RunFailure)
setStringFromMap(messagesMap, "detection-failure", &config.DetectionFailure)
setStringFromMap(messagesMap, "agent-failure-issue", &config.AgentFailureIssue)
setStringFromMap(messagesMap, "agent-failure-comment", &config.AgentFailureComment)
Comment on lines +37 to +48
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parseMessagesConfig now sets detection-failure, agent-failure-issue, and agent-failure-comment via the new helper, but the existing TestParseMessagesConfig assertions (in pkg/workflow/safe_outputs_test.go) don’t cover these fields (or append-only-comments). Adding/expanding tests to assert these mappings would help catch accidental key/field mixups during refactors like this.

Copilot uses AI. Check for mistakes.

return config
}
Expand Down