Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/githubnext/gh-aw-internal/pull/764/
This PR completely removes the
max-runsfeature from gh-aw workflows as requested, while preserving the existingstop-timefunctionality for cost control.Changes Made
Core Implementation:
MaxRunsfield fromWorkflowDatastructmax-runsparsing from workflow frontmatter processinggenerateSafetyChecks()function to only handlestop-timechecksmax-runsfield with proper validationDocumentation Updates:
docs/frontmatter.mdto remove max-runs sectiondocs/workflow-structure.mdexamplespkg/cli/templates/.github/instructions/filesWorkflow Updates:
max-runs: 1from.github/workflows/daily-qa.mdValidation
The implementation has been thoroughly tested:
Generated workflows now only include stop-time safety checks that validate the deadline and disable the workflow if the time limit is reached:
All existing tests pass and all 23 workflow files in the repository recompile successfully without the max-runs functionality.
Fixes #684.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
api.contoso.com/tmp/go-build668954542/b260/cli.test -test.testlogfile=/tmp/go-build668954542/b260/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true(dns block)/tmp/go-build2792383895/b260/cli.test -test.testlogfile=/tmp/go-build2792383895/b260/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true(dns block)/tmp/go-build2075455822/b260/cli.test -test.testlogfile=/tmp/go-build2075455822/b260/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true(dns block)If you need me to access, download, or install something from one of these locations, you can either: