[WIP] Address feedback from review on starlight docs PR#755
Merged
pelikhan merged 4 commits intopelikhan/astrofrom Sep 12, 2025
Merged
[WIP] Address feedback from review on starlight docs PR#755pelikhan merged 4 commits intopelikhan/astrofrom
pelikhan merged 4 commits intopelikhan/astrofrom
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
pelikhan
reviewed
Sep 12, 2025
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
pelikhan
reviewed
Sep 12, 2025
.github/workflows/docs.yml
Outdated
| path: ./docs/dist | ||
|
|
||
| deploy: | ||
| if: github.event_name == 'workflow_dispatch' || github.event_name == 'release' || github.event_name == 'push' |
Contributor
Author
There was a problem hiding this comment.
Removed push event from deploy job condition. Now the deploy job only runs on workflow_dispatch and release events, while the build job still runs on push to docs/** for validation. (commit: 125eb5f)
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
pelikhan
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrating docs to starlight.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.