Skip to content

[WIP] Address feedback from review on starlight docs PR #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 4 commits into from
Sep 12, 2025
Merged

[WIP] Address feedback from review on starlight docs PR #755

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5f586c2
Initial plan
Copilot Sep 11, 2025
e2ad80b
Apply review comments to docs.yml workflow
Copilot Sep 12, 2025
125eb5f
Add push event type to deploy job condition in docs.yml workflow
Copilot Sep 12, 2025
28dece6
Remove push event from deploy job condition in docs.yml workflow
Copilot Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ on:
workflow_dispatch:
release:
types: [created]
push:
paths:
- 'docs/**'

# Allow this job to clone the repo and create a page deployment
permissions:
Expand All @@ -14,7 +17,7 @@ permissions:
# Allow only one concurrent deployment, skipping runs queued between the run in-progress and latest queued.
# However, do NOT cancel in-progress runs as we want to allow these production deployments to complete.
concurrency:
group: "pages"
group: "pages-${{ github.ref }}"
cancel-in-progress: false

jobs:
Expand Down Expand Up @@ -45,6 +48,7 @@ jobs:
path: ./docs/dist

deploy:
if: github.event_name == 'workflow_dispatch' || github.event_name == 'release'
environment:
name: github-pages
url: ${{ steps.deployment.outputs.page_url }}
Expand Down