Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labeler always correctly adds expected label, but sometimes then incorrectly immediately and unexpectedly removes the label #46

Closed
sideshowbarker opened this issue May 23, 2022 · 3 comments

Comments

@sideshowbarker
Copy link

sideshowbarker commented May 23, 2022

For MDN we’re using v2.5 to label just new issues (not to re-label existing ones) and it works as expected almost all the time — but occasionally it will unexpectedly remove a label it has just added.

mdn/content#16309 (comment) is an example.

The relevant config files are here:

https://gist.github.com/sideshowbarker/c25f8f87747c68d0409c14db9b56bcd9 is a copy of the raw log for the workflow run.

In looking at that log, I notice that while there’s an event logged for when the expected label is added, there’s actually no event logged that shows it being removed.

Note that in addition to github/issue-labeler, we also run andymckay/labeler, to do just one thing: add a needs-triage label.

The config file for that is at https://github.com/mdn/content/blob/main/.github/workflows/new-issues.yml

@sideshowbarker sideshowbarker changed the title Labeler sometimes correctly adds expected label, but then incorrectly immediately and unexpectedly removes the label Labeler always correctly adds expected label, but sometimes then incorrectly immediately and unexpectedly removes the label May 23, 2022
@stephanmiehe
Copy link
Collaborator

@sideshowbarker please try v2.6 and let us know if this is still an issue

@sideshowbarker
Copy link
Author

@sideshowbarker please try v2.6 and let us know if this is still an issue

Along with upgrading to v2.6+, do we need to manually set sync-labels: 0 to prevent this issues?

@wavingtowaves
Copy link

@sideshowbarker I'm having the same issue as you with this action. Can you describe what worked for you to resolve this?

I'm currently using github/issue-labeler@v2.5 and sync-labels: 0 and sync-labels: 1 both remove pre-existing labels if regex doesn't match exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants