Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(issue-regex-labeler): remove sync-labels option #25377

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Mar 16, 2023

Description

Fixes #25373.

Removes the sync-labels option from the github/issue-labeler action in the issue-regex-labeler workflow.

Motivation

github/issue-labeler v3 introduced the following breaking change: "Issue labels that do not match a regex will no longer be removed by default unless you set sync-labels: to 1"

So we added sync-labels: 1 to keep the previous behavior.

However, we only label new issues, not existing issues, so the action does not need to sync or remove any labels.

Additional details

See this failing workflow run.

Related issues and pull requests

See also:

github/issue-labeler v3 introduced the following breaking
change: "Issue labels that do not match a regex will no longer
be removed by default unless you set sync-labels: to 1"

So we added `sync-labels: 1` to keep the previous behavior.

However, we only label new issues, not existing issues,
so the action does not need to sync or remove any labels.
@caugner caugner requested a review from bsmth March 16, 2023 12:08
@caugner caugner requested a review from a team as a code owner March 16, 2023 12:08
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @caugner - I think this is the correct fix here 👍🏻

@caugner caugner merged commit dfc39e1 into main Mar 16, 2023
@caugner caugner deleted the remove-sync-labels-option-from-issue-labeler branch March 16, 2023 12:11
@bsmth bsmth mentioned this pull request Mar 16, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failure with issue labeler workflow for Firefox release issues
2 participants