feat: add sync-labels option #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balazsorban44
changed the title
balazsorban44
commented
Feb 1, 2023
action.yml
Outdated
| sync-labels: | ||
| description: 'Remove the label from the issue if the label regex does not match' | ||
| required: false | ||
| default: "1" |
There was a problem hiding this comment.
Arguably, this should be 0 by default. The current behavior does not make sense. This action tries removing labels that do not exist, throwing a bunch of 404 errors.
This would probably require releasing as a major though, so I'll leave it up to you.
There was a problem hiding this comment.
Agreed. I don't mind doing a major for this. I'll get this updated and merged in
There was a problem hiding this comment.
IMHO, it would be nice, if this feature ("Remove the label from the issue if the label regex does not match") would still be available. But of course in the current state it throws a lot of "wrong" errors. It would be great if you could fix it, but I don't know how much work this is. Disabling this feature by default is surely better than getting all these errors
There was a problem hiding this comment.
I should be able to get a release out today or tomorrow which will default to not removing the label but still giving you the option to enable that feature
This was referenced Feb 8, 2023
stephanmiehe
approved these changes
Feb 8, 2023
jankaifer
pushed a commit
to balazsorban44/issue-labeler
that referenced
this pull request
Feb 16, 2023
* Add 'sync-labels' to README.md * feat: add `sync-labels` option * Update action.yml * Update docs --------- Co-authored-by: Kaeden Wile <kaeden.wile@asurion.com> Co-authored-by: Stephan Miehe <49914758+stephanmiehe@users.noreply.github.com>
jankaifer
pushed a commit
to balazsorban44/issue-labeler
that referenced
this pull request
Feb 16, 2023
* Add 'sync-labels' to README.md * feat: add `sync-labels` option * Update action.yml * Update docs --------- Co-authored-by: Kaeden Wile <kaeden.wile@asurion.com> Co-authored-by: Stephan Miehe <49914758+stephanmiehe@users.noreply.github.com>
kodiakhq bot
referenced
this pull request
in X-oss-byte/Canary-nextjs
Oct 10, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github/issue-labeler](https://togithub.com/github/issue-labeler) | action | major | `v2.6` -> `v3.2` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>github/issue-labeler (github/issue-labeler)</summary> ### [`v3.2`](https://togithub.com/github/issue-labeler/releases/tag/v3.2) [Compare Source](https://togithub.com/github/issue-labeler/compare/v3.1...v3.2) #### What's Changed - fix: read default token by [@​EndBug](https://togithub.com/EndBug) in [https://github.com/github/issue-labeler/pull/67](https://togithub.com/github/issue-labeler/pull/67) - feat: allow the use of custom issue numbers by [@​EndBug](https://togithub.com/EndBug) in [https://github.com/github/issue-labeler/pull/66](https://togithub.com/github/issue-labeler/pull/66) - fix: Use the correct input name so the default applies by [@​phated](https://togithub.com/phated) in [https://github.com/github/issue-labeler/pull/72](https://togithub.com/github/issue-labeler/pull/72) - feat: Add outputs of the labels added and removed by [@​phated](https://togithub.com/phated) in [https://github.com/github/issue-labeler/pull/71](https://togithub.com/github/issue-labeler/pull/71) - docs: GITHUB_TOKEN passing is required by [@​rajbos](https://togithub.com/rajbos) in [https://github.com/github/issue-labeler/pull/75](https://togithub.com/github/issue-labeler/pull/75) - feat: add option to include/exclude body as regex target by [@​amerikan](https://togithub.com/amerikan) in [https://github.com/github/issue-labeler/pull/70](https://togithub.com/github/issue-labeler/pull/70) #### New Contributors - [@​EndBug](https://togithub.com/EndBug) made their first contribution in [https://github.com/github/issue-labeler/pull/67](https://togithub.com/github/issue-labeler/pull/67) - [@​phated](https://togithub.com/phated) made their first contribution in [https://github.com/github/issue-labeler/pull/72](https://togithub.com/github/issue-labeler/pull/72) - [@​rajbos](https://togithub.com/rajbos) made their first contribution in [https://github.com/github/issue-labeler/pull/75](https://togithub.com/github/issue-labeler/pull/75) - [@​amerikan](https://togithub.com/amerikan) made their first contribution in [https://github.com/github/issue-labeler/pull/70](https://togithub.com/github/issue-labeler/pull/70) **Full Changelog**: github/issue-labeler@v3.1...v3.2 ### [`v3.1`](https://togithub.com/github/issue-labeler/releases/tag/v3.1) [Compare Source](https://togithub.com/github/issue-labeler/compare/v3.0...v3.1) #### What's Changed - Support empty body and only remove existing labels by [@​dokimiki](https://togithub.com/dokimiki) in [https://github.com/github/issue-labeler/pull/62](https://togithub.com/github/issue-labeler/pull/62) #### New Contributors - [@​dokimiki](https://togithub.com/dokimiki) made their first contribution in [https://github.com/github/issue-labeler/pull/62](https://togithub.com/github/issue-labeler/pull/62) **Full Changelog**: github/issue-labeler@v3.0...v3.1 ### [`v3.0`](https://togithub.com/github/issue-labeler/releases/tag/v3.0) [Compare Source](https://togithub.com/github/issue-labeler/compare/v2.6...v3.0) #### What's Changed Breaking change: Issue labels that do not match a regex will no longer be removed by default unless you set `sync-labels:` to 1 - feat: add sync-labels option by [@​balazsorban44](https://togithub.com/balazsorban44) in [https://github.com/github/issue-labeler/pull/59](https://togithub.com/github/issue-labeler/pull/59) **Full Changelog**: github/issue-labeler@v2.6...v3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/X-oss-byte/Canary-nextjs).
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically the same as #50, but bringing it up to date. Also cleaning up some log messages.
Closes #50, Fixes #12