-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump github/issue-labeler from 2.6 to 3.0 #24319
Bump github/issue-labeler from 2.6 to 3.0 #24319
Conversation
Bumps [github/issue-labeler](https://github.com/github/issue-labeler) from 2.6 to 3.0. - [Release notes](https://github.com/github/issue-labeler/releases) - [Commits](github/issue-labeler@v2.6...v3.0) --- updated-dependencies: - dependency-name: github/issue-labeler dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
I wonder if we should enable the |
From what I gather according to the release notes, it looks like this won't make a difference for us:
Issues coming from pages are using the issue template, this breaking change will not remove labels by default if someone adds one e.g. from here is that correct? |
@bsmth Based on the changes in the upstream PR, labels are no longer removed if the corresponding regex no longer matches. Example: Let's say a PR updates a CSS page, then the labeler will assign the I think we do want to set |
@caugner AFAICT, this workflow is only used to label issues, not PRs. |
You're right, I mixed it up with the PR labeler. I guess issue descriptions change so rarely that it's kind of an edge case, but maybe still worth keeping the previous behavior? |
I'm going to add this to this PR |
Bumps github/issue-labeler from 2.6 to 3.0.
Release notes
Sourced from github/issue-labeler's releases.
Commits
cd54a96
fix for 3.0be327c6
feat: add sync-labels option (#59)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)