Normalize file resource titles

[ahayworth]

Overview

This pull request slightly relaxes validation for (require/before/subscribe/notify) and friends on file resource types. Or rather, more closely matches puppet behavior.

We've noticed a problem at Braintree along the lines of:

  file { '/foo':
    ensure => directory,
  }

  file { '/bar':
    ensure => directory,
    require => File['/foo/'],
  }

This catalog compiles and is valid, but fails validation in octocatalog-diff.
It seems that puppet itself attempts to normalize file resource titles (and indeed
can normalize any type of resource title, given that a methodology exists in the
resource type). See:
https://github.com/puppetlabs/puppet/blob/4.10.x/lib/puppet/type/file.rb#L42

This commit attmepts to mimic that (and lifts the regex directly from the 4.10.x
branch of puppet, because it doesn't matter in puppet 5 since reference validation
is built-in).

This fixes #174 . NB - I made a mistake in the original commit message around which specific resource requirements were incorrectly flagged as invalid; this PR message is accurate.

Checklist

• Make sure that all of the tests pass, and fix any that don't. Just run rake in your checkout directory, or review the CI job triggered whenever you push to a pull request.
• Make sure that there is 100% test coverage by running rake coverage:spec or ignoring untestable sections of code with # :nocov comments. If you need help getting to 100% coverage please ask; however, don't just submit code with no tests.

[ahayworth]

I'll investigate these build failures. I can't reproduce them locally but I suspect the integration tests are also not running locally...

[kpaulisse]

You can run all of the integration tests like so:

bundle exec rake spec:integration

In this case the one integration test that seems to be failing is this one:

bundle exec rspec ./spec/octocatalog-diff/integration/reference_validation_spec.rb

<snip>
       	Error: Syntax error at '[' at /var/folders/dw/5ftmkqk972j_kw2fdjyzdqdw0000gn/T/ocd-ipc-20180213-36294-3s4mls/ocd-builddir-20180213-36530-b1y7eg/environments/production/modules/test/manifests/file_tests.pp:8:21 on node rspec-node.github.net
       	Error: Syntax error at '[' at /var/folders/dw/5ftmkqk972j_kw2fdjyzdqdw0000gn/T/ocd-ipc-20180213-36294-3s4mls/ocd-builddir-20180213-36530-b1y7eg/environments/production/modules/test/manifests/file_tests.pp:8:21 on node rspec-node.github.net
       	Error: Failed to compile catalog for node rspec-node.github.net: Syntax error at '[' at /var/folders/dw/5ftmkqk972j_kw2fdjyzdqdw0000gn/T/ocd-ipc-20180213-36294-3s4mls/ocd-builddir-20180213-36530-b1y7eg/environments/production/modules/test/manifests/file_tests.pp:8:21 on node rspec-node.github.net

It looks like Puppet doesn't like the space between File and ['/foo'] in the fixture, ./spec/octocatalog-diff/fixtures/repos/reference-validation/modules/test/manifests/file_tests.pp.

Also 🤞 that #178 will improve things on our Travis CI builds.

[ahayworth]

It's days like these that I'm reminded that I'm really not an app developer anymore. ^_^

Integration tests passed locally after fixing that spacing issue and you know, actually running them - I've squashed the fixes and hopefully the builds pass in CI this time around. :)

[kpaulisse]

Hey @ahayworth great news -- it looks like CI is passing now. 😸 👍

Are you finished working on this now, and ready for me to put it through our normal pre-release testing? Or do you still have additional work before we test it?

[ahayworth]

As far as I know, it’s done. This solves the problems we were seeing in our env. Test away! 😁 - Andrew Hayworth

…

On Feb 14, 2018, at 4:13 PM, Kevin Paulisse ***@***.***> wrote: Hey @ahayworth great news -- it looks like CI is passing now. 😸 👍 Are you finished working on this now, and ready for me to put it through our normal pre-release testing? Or do you still have additional work before we test it? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[kpaulisse]

I've merged this into #180 so my current plan is to test #180 internally at GitHub and then once that is 👍 merge both at the same time.

[ahayworth]

Sounds great, thank you! - Andrew Hayworth

…

On Feb 28, 2018, at 3:42 PM, Kevin Paulisse ***@***.***> wrote: I've merged this into #180 so my current plan is to test #180 internally at GitHub and then once that is 👍 merge both at the same time. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.