Split the puppet versions in hopes the tests don't timeout #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpaulisse
force-pushed
the
kpaulisse-split-tests
branch
from
d3c8d06 to
76283cf
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the jobs were timing out when a single job ran the test suite for multiple puppet versions. The underlying cause seems to be that certain travis containers are much slower than others, and there was too much work to be done to finish in time on a slower container. Another thing I observed was that some tests seemed to get stuck. This PR attempts to address this to make the CI suites more reliable.
General improvements are made:
Splits up the Travis CI tests so one job runs per ruby version + puppet version. This reduces by (approximately) a factor of 3 the amount of processing any specific job must do.
Splits up the integration tests to run one at a time, with a timeout per test set. Occasionally tests would seem to get stuck, so this will kill and retry those tests.
Added a coverage report for the rspec unit tests. (Also fixed one item that was showing as uncovered in coverage tests that were run on Travis, but not those run on my own system.) This is currently informational only, i.e. it does not fail the build.