Skip to content

Conversation

@umutphp
Copy link
Contributor

@umutphp umutphp commented May 18, 2021

  • Have you followed the contributing guidelines?
  • Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


I translated the newly added texts after my last translation.

PS: I am using GitLocalize as the translation tool. It sometimes creates formatting problems and I corrected them manually.

@umutphp umutphp requested a review from a team May 18, 2021 23:19
@umutphp umutphp requested a review from a team as a code owner May 18, 2021 23:19
umutphp and others added 2 commits May 19, 2021 02:23
* Bump actions/setup-ruby from 1 to 1.1.3

Bumps [actions/setup-ruby](https://github.com/actions/setup-ruby) from 1 to 1.1.3.
- [Release notes](https://github.com/actions/setup-ruby/releases)
- [Commits](actions/setup-ruby@v1...v1.1.3)

Signed-off-by: dependabot[bot] <support@github.com>

* Fix formating errors created by Gitlocalize (#35)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Blake Williams <blakewilliams@github.com>
@adirusland

This comment has been minimized.

Bocoi5011
Bocoi5011 previously approved these changes May 27, 2021
@github github deleted a comment May 31, 2021
enforcing-your-code-of-conduct: Davranış kurallarınızı güçlendirmek
enforcing-your-code-of-conduct: Davranış kurallarınızı uygulama
your-responsibilities-as-a-maintainer: Bir koruyucu olarak sorumluluklarınız
order: 8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, I think we need these to stay as integers in order for the frontmatter to be read correctly!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @deniseyu ,

Many thanks for the review.

I don't know why they were deleted. Probably, the translation tool that I am using caused this. I will check all the files too and fix the same issues if there are any.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem! I also share your suspicion that the tool did it! Let me know if you need any help with scoping down this PR to only contain the awesome translations!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @deniseyu ,

I think I have fixed all the issues in Turkish translation files. But, the test fails in a Chinese file because of the failure of an external url.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @umutphp for fixing this! I'm looking into that failure right now, and will take care of it, no further action needed from you. Thanks for your patience!

Copy link
Contributor

@deniseyu deniseyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the updated translations @umutphp!

The formatting and frontmatter of the previous version looked like they were OK, and I believe we need the order integers (ex. order: 8) to stay as integers and not strings in order for the pages to be generated in the expected order.

If you can revert the non-translation changes in this PR, and fix the failing test, I'd be happy to approve and merge.

The order values in the articales should be integer.
See: github#2411 (comment)
@umutphp umutphp dismissed a stale review via c77ffee May 31, 2021 16:02
@deniseyu
Copy link
Contributor

deniseyu commented Jun 1, 2021

hey @umutphp, we've resolved the failing tests in #2431 - if you can merge main in to your branch, this should be good to go!

@umutphp
Copy link
Contributor Author

umutphp commented Jun 1, 2021

hey @umutphp, we've resolved the failing tests in #2431 - if you can merge main in to your branch, this should be good to go!

Hi @deniseyu,

Your resolution worked :). Many thanks for your assistance on this PR.

@deniseyu
Copy link
Contributor

deniseyu commented Jun 1, 2021

thank YOU @umutphp for your patience! ✨

@deniseyu deniseyu merged commit a89914c into github:main Jun 1, 2021
@Badreah87

This comment has been minimized.

@Badreah87

This comment has been minimized.

@yogiwahyuuu
Copy link

Merge brand "main"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants