-
Notifications
You must be signed in to change notification settings - Fork 15.1k
Update Turkish Translations #2411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Merge Master
Update From Main Repo
Update From Main
_articles/tr/how-to-contribute.md
_articles/tr/code-of-conduct.md
_articles/tr/finding-users.md
_articles/tr/starting-a-project.md
_articles/tr/starting-a-project.md
_articles/tr/starting-a-project.md
* Bump actions/setup-ruby from 1 to 1.1.3 Bumps [actions/setup-ruby](https://github.com/actions/setup-ruby) from 1 to 1.1.3. - [Release notes](https://github.com/actions/setup-ruby/releases) - [Commits](actions/setup-ruby@v1...v1.1.3) Signed-off-by: dependabot[bot] <support@github.com> * Fix formating errors created by Gitlocalize (#35) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Blake Williams <blakewilliams@github.com>
This comment has been minimized.
This comment has been minimized.
| enforcing-your-code-of-conduct: Davranış kurallarınızı güçlendirmek | ||
| enforcing-your-code-of-conduct: Davranış kurallarınızı uygulama | ||
| your-responsibilities-as-a-maintainer: Bir koruyucu olarak sorumluluklarınız | ||
| order: 8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi, I think we need these to stay as integers in order for the frontmatter to be read correctly!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @deniseyu ,
Many thanks for the review.
I don't know why they were deleted. Probably, the translation tool that I am using caused this. I will check all the files too and fix the same issues if there are any.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no problem! I also share your suspicion that the tool did it! Let me know if you need any help with scoping down this PR to only contain the awesome translations!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @deniseyu ,
I think I have fixed all the issues in Turkish translation files. But, the test fails in a Chinese file because of the failure of an external url.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @umutphp for fixing this! I'm looking into that failure right now, and will take care of it, no further action needed from you. Thanks for your patience!
deniseyu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for the updated translations @umutphp!
The formatting and frontmatter of the previous version looked like they were OK, and I believe we need the order integers (ex. order: 8) to stay as integers and not strings in order for the pages to be generated in the expected order.
If you can revert the non-translation changes in this PR, and fix the failing test, I'd be happy to approve and merge.
The order values in the articales should be integer. See: github#2411 (comment)
Emphasis should use `_` as a marker
Emphasis should use `_` as a marker
|
thank YOU @umutphp for your patience! ✨ |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Merge brand "main" |
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.
I translated the newly added texts after my last translation.
PS: I am using GitLocalize as the translation tool. It sometimes creates formatting problems and I corrected them manually.