-
Notifications
You must be signed in to change notification settings - Fork 36
Description
Summary
This PR fixes CI test failures in the pkg/workflow package by addressing missing validation phrases in the jsweep workflow and adding GitHub Actions snapshot feature support to the workflow schema.
Changes Made
1. Fixed jsweep.md Workflow Test Requirements
The TestJSweepWorkflowConfiguration test was failing because the jsweep workflow was missing specific validation phrases. Added the following required text:
- TypeScript validation: Added "verify no type errors" and "type safety" to emphasize the importance of type checking
- Prettier formatting: Added "ensure consistent formatting" to reinforce formatting standards
- Test verification: Added "verify all tests pass" to clarify test requirements
These changes improve the workflow instructions by making validation requirements more explicit for contributors.
2. Added GitHub Actions Snapshot Support
Updated pkg/workflow/schemas/github-workflow.json to add support for the snapshot keyword in job definitions. This enables custom image generation for GitHub Actions workflows:
- Added
snapshotdefinition with support for both string and mapping syntax - Supports
image-nameand optionalversionproperties - Includes proper JSON schema validation for version patterns
Since schema files are embedded using //go:embed directives, rebuilt the binary to include the schema changes.
3. Recompiled All Workflows
After schema changes, recompiled all workflow lock files to ensure they use the latest schema validation. Compiled 130 workflows successfully with expected warnings about:
- Schedule fuzzy timing recommendations
- Campaign spec missing workflow files (known issue - those workflows don't exist yet)
Validation
✅ All Go tests passing:
go test -short ./...
- All packages: ✅ PASS
- pkg/workflow: ✅ PASS (was failing before)
- TestJSweepWorkflowConfiguration: ✅ PASS (was failing before)
✅ Code formatted with go fmt
✅ Workflows recompiled successfully
Notes
- Known issue: The
mcp-inspector.mdworkflow fails compilation due to an npm environment issue (Cannot find module '../lib/cli.js'). This is a pre-existing environment problem not introduced by these changes. - All other 129 workflows compile successfully
CI Cleaner Report
Run: #333
Triggered by: Scheduled CI health check (twice daily at 6am/6pm UTC)
Issues Found:
- Test failures in
pkg/workflowpackage - Missing validation phrases in jsweep.md workflow
- Schema file changes required binary rebuild
Issues Fixed:
- ✅ Updated jsweep.md with required validation phrases
- ✅ Added snapshot support to GitHub Actions schema
- ✅ Rebuilt binary after schema changes
- ✅ Recompiled all workflow lock files
- ✅ All tests now passing
CI Status: ✅ All checks passing (except pre-existing npm environment issue in mcp-inspector.md)
AI generated by CI Cleaner
Note
This was originally intended as a pull request, but the git push operation failed.
Workflow Run: View run details and download patch artifact
The patch file is available as an artifact (aw.patch) in the workflow run linked above.
To apply the patch locally:
# Download the artifact from the workflow run https://github.com/githubnext/gh-aw/actions/runs/20643122996
# (Use GitHub MCP tools if gh CLI is not available)
gh run download 20643122996 -n aw.patch
# Apply the patch
git am aw.patchShow patch preview (500 of 766 lines)
From c27c1079384ed4f84063bbea79d03d262290dd02 Mon Sep 17 00:00:00 2001
From: CI Cleaner Bot <ci-cleaner@github.com>
Date: Thu, 1 Jan 2026 18:18:37 +0000
Subject: [PATCH] fix: update jsweep workflow test requirements and add
snapshot support to schema
- Add required phrases to jsweep.md to satisfy test expectations
- Update schema to support GitHub Actions snapshot feature for custom images
- Recompile all workflow lock files after schema change
The jsweep workflow test was failing because it expected specific phrases:
- 'verify no type errors' and 'type safety' for TypeScript validation
- 'ensure consistent formatting' for prettier formatting
- 'verify all tests pass' for test verification
Added these phrases to the workflow instructions to ensure proper validation
guidance for contributors.
Also updated github-workflow.json schema to add snapshot support for
custom image generation in GitHub Actions workflows.
---
.../agent-performance-analyzer.lock.yml | 2 +-
.github/workflows/audit-workflows.lock.yml | 2 +-
.github/workflows/campaign-manager.lock.yml | 2 +-
.../workflows/cli-version-checker.lock.yml | 2 +-
.../workflows/copilot-agent-analysis.lock.yml | 2 +-
.../copilot-pr-prompt-analysis.lock.yml | 2 +-
.../copilot-session-insights.lock.yml | 2 +-
.../daily-assign-issue-to-user.lock.yml | 2 +-
.../workflows/daily-cli-performance.lock.yml | 2 +-
.github/workflows/daily-code-metrics.lock.yml | 2 +-
.github/workflows/daily-doc-updater.lock.yml | 2 +-
.../workflows/daily-firewall-report.lock.yml | 2 +-
.../workflows/daily-issues-report.lock.yml | 2 +-
.../daily-malicious-code-scan.lock.yml | 2 +-
.../daily-multi-device-docs-tester.lock.yml | 2 +-
.../daily-performance-summary.lock.yml | 2 +-
.../workflows/daily-workflow-updater.lock.yml | 2 +-
.../developer-docs-consolidator.lock.yml | 2 +-
.github/workflows/docs-noob-tester.lock.yml | 2 +-
.../duplicate-code-d
... (truncated)