Fix missing safe outputs in GITHUB_AW_SAFE_OUTPUTS_CONFIG #333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GITHUB_AW_SAFE_OUTPUTS_CONFIGenvironment variable was missing several safe output types, causing validation failures during workflow execution. ThegenerateOutputCollectionStepfunction inpkg/workflow/compiler.goonly included a subset of the available safe output types.Problem
When workflows used
create-discussion,create-pull-request-review-comment, orcreate-security-reportsafe outputs, theGITHUB_AW_SAFE_OUTPUTS_CONFIGenvironment variable didn't include these configurations. This caused the output collection step to reject valid output items with "Unexpected output type" errors.Solution
Added the missing safe output configurations to the
generateOutputCollectionStepfunction:create-discussion: Includesenabled: trueand respects themaxconfiguration from frontmattercreate-pull-request-review-comment: Includesenabled: trueand respects themaxconfiguration from frontmattercreate-security-report: Includesenabled: trueand respects themaxconfiguration from frontmatterBefore vs After
Before: A workflow with
create-discussionwould generate:After: The same workflow now generates:
Testing
TestSafeOutputsConfigGenerationto validate configuration generationThe fix ensures that all safe output types defined in the
SafeOutputsConfigstruct are properly handled in the validation configuration, preventing runtime validation errors.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
api.contoso.com/tmp/go-build1567927563/b278/cli.test -test.testlogfile=/tmp/go-build1567927563/b278/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true(dns block)/tmp/go-build2757072128/b278/cli.test -test.testlogfile=/tmp/go-build2757072128/b278/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true(dns block)/tmp/go-build2165124624/b278/cli.test -test.testlogfile=/tmp/go-build2165124624/b278/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.